Skip to content

Conversation

@ok-nick
Copy link
Contributor

@ok-nick ok-nick commented Nov 20, 2025

This PR changes the Valid validation state logic to accept the untrusted credential failure code for the active manifest.

Should we be checking for the claim signature validated and claim signature inside validity success codes for all of the ingredients too? By extension, should we be checking that all of the ingredients have a trusted success code (rather than only check for no error codes) for the active manifest to be Trusted? See #1624

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 20, 2025

CodSpeed Performance Report

Merging #1623 will not alter performance

Comparing ok-nick/fix-validation-state (3f475f2) with main (629ab6e)

Summary

✅ 16 untouched
⏩ 2 skipped1

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Collaborator

@mauricefisher64 mauricefisher64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ok-nick ok-nick merged commit 17ce72e into main Nov 25, 2025
44 checks passed
@ok-nick ok-nick deleted the ok-nick/fix-validation-state branch November 25, 2025 21:47
@caiopensrc caiopensrc mentioned this pull request Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants