Skip to content

fix: Apply same restrictions on ingredient deltas as active manifest for validation state #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Apply same restrictions on ingredient deltas as active manifest for validation state #1624

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
437a672
fix: Allow untrusted failure code to be a Valid validation state
ok-nick Nov 20, 2025
9fa5071
fix: Apply same restrictions on ingredient deltas as active manifest …
ok-nick Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 44 additions & 19 deletions sdk/src/validation_results.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,6 @@
// specific language governing permissions and limitations under
// each license.

use std::collections::HashSet;

#[cfg(feature = "json_schema")]
use schemars::JsonSchema;
use serde::{Deserialize, Serialize};
Expand Down Expand Up @@ -210,28 +208,55 @@ impl ValidationResults {
/// [§14.3. Validation states]: https://spec.c2pa.org/specifications/specifications/2.2/specs/C2PA_Specification.html#_validation_states
pub fn validation_state(&self) -> ValidationState {
if let Some(active_manifest) = self.active_manifest.as_ref() {
let success_codes: HashSet<&str> = active_manifest
.success()
.iter()
.map(|status| status.code())
.collect();
let failure_codes = active_manifest.failure();
let ingredient_failure = self.ingredient_deltas.as_ref().is_some_and(|deltas| {
deltas
fn is_manifest_valid(
success_codes: &[ValidationStatus],
failure_codes: &[ValidationStatus],
) -> bool {
success_codes
.iter()
.any(|idv| !idv.validation_deltas().failure().is_empty())
});
.any(|status| status.code() == validation_status::CLAIM_SIGNATURE_VALIDATED)
&& success_codes.iter().any(|status| {
status.code() == validation_status::CLAIM_SIGNATURE_INSIDE_VALIDITY
})
&& (failure_codes.is_empty()
|| failure_codes.iter().all(|status| {
status.code() == validation_status::SIGNING_CREDENTIAL_UNTRUSTED
}))
}

fn is_manifest_trusted(
success_codes: &[ValidationStatus],
failure_codes: &[ValidationStatus],
) -> bool {
success_codes
.iter()
.any(|status| status.code() == validation_status::SIGNING_CREDENTIAL_TRUSTED)
&& failure_codes.is_empty()
}

// https://spec.c2pa.org/specifications/specifications/2.2/specs/C2PA_Specification.html#_valid_manifest
let is_valid = success_codes.contains(validation_status::CLAIM_SIGNATURE_VALIDATED)
&& success_codes.contains(validation_status::CLAIM_SIGNATURE_INSIDE_VALIDITY)
&& failure_codes.is_empty()
&& !ingredient_failure;
let is_valid = is_manifest_valid(active_manifest.success(), active_manifest.failure())
&& self.ingredient_deltas.as_ref().iter().all(|deltas| {
deltas.iter().all(|idv| {
let deltas = idv.validation_deltas();
deltas.informational().iter().any(|status| {
status.code() == validation_status::INGREDIENT_PROVENANCE_UNKNOWN
}) || is_manifest_valid(deltas.success(), deltas.failure())
})
});

// https://spec.c2pa.org/specifications/specifications/2.2/specs/C2PA_Specification.html#_trusted_manifest
let is_trusted = success_codes.contains(validation_status::SIGNING_CREDENTIAL_TRUSTED)
&& failure_codes.is_empty()
&& is_valid;
let is_trusted =
is_manifest_trusted(active_manifest.success(), active_manifest.failure())
&& self.ingredient_deltas.as_ref().iter().all(|deltas| {
deltas.iter().all(|idv| {
let deltas = idv.validation_deltas();
deltas.informational().iter().any(|status| {
status.code() == validation_status::INGREDIENT_PROVENANCE_UNKNOWN
}) || is_manifest_trusted(deltas.success(), deltas.failure())
})
})
&& is_valid;

if is_trusted {
return ValidationState::Trusted;
Expand Down
Loading