Skip to content

Conversation

@lrosenthol
Copy link
Contributor

@lrosenthol lrosenthol commented Jan 18, 2026

Changes in this pull request

Added a new JpegTrustReader that is API compatible with the standard Reader, but will output a JPEG Trust (ISO 21617-1) compatible Trust Indicator Set instead of the current c2pa-rs JSON structure.

Also added appropriate unit tests including limited "schema validation".

Various documentation on the work performed (by Cursor) is included as well, but could/should be removed at some point.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@lrosenthol lrosenthol marked this pull request as draft January 18, 2026 16:30
@tmathern
Copy link
Contributor

tmathern commented Jan 21, 2026

@lrosenthol I am changing the PR's title to follow conventional commits, to give the tests a chance to get to run + adding the safe to test label.
(I assume we want them to run even if the PR is a draft).

@tmathern tmathern changed the title Add support for exporting a JPEG Trust Trust Indicator Set feat: Add support for exporting a JPEG Trust Trust Indicator Set Jan 21, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 21, 2026

CodSpeed Performance Report

Merging this PR will improve performance by 10.79%

Comparing jpeg-trust-manifests (3674421) with main (420bca8)

Summary

⚡ 1 improved benchmark
✅ 15 untouched benchmarks
⏩ 2 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
sign 100kb jpeg 5 ms 4.5 ms +10.79%

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@tmathern
Copy link
Contributor

(If you merge in latest main, the build issues will resolve)

@lrosenthol
Copy link
Contributor Author

Pulled it in - thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants