Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
I have added a new Github Action workflow to perform conpatibility checks between the base branch and the pull request branch.
Related Issue: #1911
I'm aware there was earlier work in #513 .
My understanding is that the previous approach aimed for a much stricter comparison, including format-level checks with multiple asset types.
This PR intentionally takes a lighter approach. Instead of enforcing exact snapshot matches, it uses
c2patoolto run practical forward and backward compatibility checks.One possible concern with the previous PR is that the workflow may fail if compatibility is broken due to spec changes.
That is also part of the motivation for this work.
If a spec or implementation change causes compatibility to break, that should be handled as a critical event.
And this is need to be detected as early as possible, before it impacts downstream solutions built on this repository.
There are two behavior for compatibility.
basesigns a sample asset,PRreads it.PRsigns a sample asset,basereads it.This PR uses trigger conditions similar to
tier-1a, but I'm happy to adjust if needed.Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.