-
Notifications
You must be signed in to change notification settings - Fork 7
Reorganize, clarify, and update docs on signing and certs #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Deployed on https://deploy-preview-207--cai-open-source.netlify.app |
docs/signing/local-signing.md
Outdated
|
||
Where `mycerts.pub` is the file containing the certificate chain from signing certificate to the last certificate before the root CA, concatenated. | ||
|
||
This command produces a text summary of the certificate properties, as shown in the example below. Look for a line containing `Signature Algorithm`. The public key indicates the signature algorithm used. See the table in [Getting a certificate](get-cert.md#signature-types) to determine the corresponding signature type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look for a line containing Signature Algorithm
.
should be
Look for a line containing Public Key Algorithm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sorry I just noticed this and fixed it.
docs/signing/local-signing.md
Outdated
|
||
This command produces a text summary of the certificate properties, as shown in the example below. Look for a line containing `Signature Algorithm`. The public key indicates the signature algorithm used. See the table in [Getting a certificate](get-cert.md#signature-types) to determine the corresponding signature type. | ||
|
||
For this example with a certificate issued by GlobalSign, `Signature Algorithm: sha256WithRSAEncryption` corresponds to the PS256 signature type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signature Algorithm: sha256WithRSAEncryption
should be
'Public Key Algorithm: rsassaPss' with PSS parameter 'Hash Algorithm: SHA2-256'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed that already as well, basically right as you commented. Small difference: I used the literal text from the table in https://deploy-preview-207--cai-open-source.netlify.app/docs/signing/get-cert#signature-types, so:
RSASSA-PSS with SHA-256
Instead of
RSASSA-PSS with PSS parameter 'Hash Algorithm: SHA2-256
If you prefer, I can change both to be the latter.
There was info on signing and certs in several different places. This PR consolidates and reorganizes it with some edits and clarifications:
New/reorganized pages: