Skip to content

Hubspot improvements [] #10040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joaquincasal merged 4 commits into from
Jul 31, 2025
Merged

Hubspot improvements [] #10040

joaquincasal merged 4 commits into from
Jul 31, 2025

Conversation

@joaquincasal
Copy link
Collaborator

@joaquincasal joaquincasal commented Jul 31, 2025 •
edited
Loading

Purpose

Address PR comments for the Hubspot app

Approach

  • Config screen: set the error outside of the checkIfHasValue function
  • Replace CMA usages for sdk.cma instead of creating it with createClient
  • Remove an unnecessary try/catch block in the page screen (as it was already surrounded by another try/catch)
  • Add deploy script

@joaquincasal joaquincasal requested a review from a team as a code owner July 31, 2025 12:00
@netlify
Copy link

netlify bot commented Jul 31, 2025 •
edited
Loading

✅ Deploy Preview for ecommerce-app-base-components canceled.

Name Link
🔨 Latest commit 78b9aa9
🔍 Latest deploy log https://app.netlify.com/projects/ecommerce-app-base-components/deploys/688b873fde1570000814e5c9

ryunsong-contentful
ryunsong-contentful approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@ryunsong-contentful ryunsong-contentful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@joaquincasal joaquincasal merged commit fa0885e into master Jul 31, 2025
18 checks passed
@joaquincasal joaquincasal deleted the hubspot-improvements branch July 31, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ryunsong-contentful ryunsong-contentful ryunsong-contentful approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joaquincasal @ryunsong-contentful