Braze: Disable resource link fields [INTEG-2981] #10047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecommerce-app-base-components canceled.
|
joaquincasal
changed the title
JuliRossi
approved these changes
Aug 5, 2025
Collaborator
JuliRossi
left a comment
JuliRossi
left a comment
There was a problem hiding this comment.
LGTM! Left a non-blocking comment
Collaborator
There was a problem hiding this comment.
💭 I feel like this class and richText have a lot in common. Perhaps there is a way to avoid duplication. On the other hand, I like that it is explicit on how we handle ExternalResourceField. So I leave it up to you if you want to remove the duplicates
Collaborator
Author
There was a problem hiding this comment.
The thing is that rich text is supported in one of the versions, that's why I kept them separate
ryunsong-contentful
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The ResourceLink field type is not supported in the Braze app. However, users were able to select them. This PR disables those fields.
Approach
The FieldFactory wasn't aware of the existance of the ResourceLink type, so it created a BasicField. Now it creates a ExternalResourceField, which is disabled for both versions of the app.
Testing steps
Try to use both versions of the app with an entry that has a ResourceLink field.