Rich Text Versioning app [INTEG-2763] #10073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: initialize rich text versioning app with basic structure and components * move tests to test folder * add config settings for vite and vitest * Taking advantage of those jest matchers * prettier
* wip wip * updated
…10054) * creating UI and call to fetch the rich text diff * adding tests and some refactors * adding more tests * adding css style to Dialog location * removing html-diff-ts that was not used * correction of PRs
…10053) * wip * wip * Fix emotion issue * simplifying and upping the state to config screen * update label * adjusting margins * adjusting labels * refactoring * fix test * update deps * fixing because conflict with 7.0 version * refsctoring test * removing unwanted test * renaming * simplifying mapping * changes per comments * fixes after merge
…3] (#10059) * creating UI and call to fetch the rich text diff * adding tests and some refactors * adding more tests * adding css style to Dialog location * removing html-diff-ts that was not used * first version of error handling * using sdk to get the published version + refactor in tests * adjusting the width and height of the dialog if there is an error * formating with prettier after rebase * updating package-lock.json * update in mockSdk to fix tests after rebase * adding css style in Dialog.styles.ts * correction of pr comments * removing some prettier format
* removing access token from the config screen * removing api key tests + ContentfulApiKeyInput component
* wip * wip * comments * joas approach! * rename * Update loading condition in HtmlDiffViewer to include diffHtml check * this doesn't need to be optional * wip * Making single call * wip * Rough error handling * Add entry title and status utilities; refactor HtmlDiffViewer and Dialog components * fix * Handling errors * removing unused * removing unused deps * Update dependencies to include @contentful/rich-text-types version 16.1.0 in package.json and package-lock.json * Fixing type issues * adding tests * entry not found * removing afterEach * adding margin bottom in createOptions embedded entry * Refactor createOptions and Dialog components to use locale parameter for entry status and title retrieval; remove unused dependencies from package.json and package-lock.json. --------- Co-authored-by: francobanfi <[email protected]>
* fix issue * Localization dIff fix
* Rich text versioning: Add asset support * Fix node type * Update tests logic for changed field
* Adjust button and deleted references styles * Remove badge
✅ Deploy Preview for ecommerce-app-base-components canceled.
|
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Contributor
|
Few things I noticed
Another example of white spaces |
Contributor
|
None of these are release blocking imo and I don't think any of them are worth the follow up work except for issue 1 with closing the modal by clicking outside the modal. I think the rest of the issues can be done if the customer complains and want these features. I will now just do a code review now that I've done some qa'ing |
| <> | ||
| <div | ||
| className={styles} | ||
| dangerouslySetInnerHTML={{ |
Contributor
There was a problem hiding this comment.
See the last commit I added here to add more security around XSS attacks.
I did a quick double check to make sure it didn't affect the final product but I encourage you to also do a check as well and make sure my commit didn't change anything other than adding more security
ryunsong-contentful
force-pushed
the
rich-text-versioning
branch
from
d74658c to
9fe6699
Compare
ryunsong-contentful
force-pushed
the
rich-text-versioning
branch
from
9fe6699 to
f49f225
Compare
ryunsong-contentful
approved these changes
Aug 22, 2025
Contributor
ryunsong-contentful
left a comment
ryunsong-contentful
left a comment
There was a problem hiding this comment.
Still having white space issues, but I'm not sure how much there is to do based on your last commit. Might be a library specific thing.
ryunsong-contentful
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This app allows content creators to visually compare changes in a rich text field against the last published version. A two-column view highlights added, removed, and modified content, including referenced entries and assets.
Approach
Testing steps
Screen.Recording.2025-08-21.at.09.47.27.mov