Skip to content

Conversation

@FBanfi
Copy link
Collaborator

@FBanfi FBanfi commented Aug 25, 2025

Purpose

This update was introduced because we needed to freeze the top row with the field names when the user scroll down and up in the entries table.

Approach

Added some css styles to make the top row sticky.

Testing steps

Grabacion.de.pantalla.2025-08-25.a.la.s.10.08.01.a.m.mov

Breaking Changes

N/A

Dependencies and/or References

Link to INTEG-2953

Deployment

N/A

@FBanfi FBanfi requested a review from a team as a code owner August 25, 2025 13:04
@netlify
Copy link

netlify bot commented Aug 25, 2025

Deploy Preview for ecommerce-app-base-components canceled.

Name Link
🔨 Latest commit 225d007
🔍 Latest deploy log https://app.netlify.com/projects/ecommerce-app-base-components/deploys/68ac5f45e95f0500086cce39

@FBanfi FBanfi changed the base branch from master to bulk-edit-v2 August 25, 2025 13:05
@FBanfi FBanfi changed the title Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953 Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] Aug 25, 2025
Copy link
Collaborator

@JuliRossi JuliRossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@FBanfi FBanfi changed the base branch from bulk-edit-v2 to bulk-edit-v1.1 August 26, 2025 14:03
@FBanfi FBanfi merged commit fec1c63 into bulk-edit-v1.1 Aug 26, 2025
14 checks passed
@FBanfi FBanfi deleted the bulk-edit-v2-integ-2953 branch August 26, 2025 15:21
JuliRossi added a commit that referenced this pull request Sep 2, 2025
* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* Bulk-Edit-App: Changing the spinner for a skeleton [INTEG-3104] (#10081)

* changing the spinner for a skeleton

* rename css style

* making the status column sticky too (#10082)

* Bulk edit [INTEG-2847] (#10074)

* Enhance performance and reduce errors by batching

* Adding create-entries and delete-entries v1 scripts

* Fixing cors size limitation

* moving scripts

* Minor fixes

* Tests and refactor

* Update .env.example to clarify optional entry count setting

* Fixing truncation for some really big texts

* Adding delete-entries modifications and tests

* generation with numbers of entries

* batching for getting large entries

* simplifying a bit

* disabling cancel botton when undoing and saving

* Set truncate to 30

* Fixing config files

* making test better and simpler

* remove duplication

* making adjustments base on comments

* Refactor entry fetching to handle batch sizes and improve response limits

---------

Co-authored-by: francobanfi <[email protected]>

* Bulk-Edit-App: Show the progress of the edition [INTEG-3106] (#10085)

* adding progress in modal and tests

* formating with prettier

* creating generic progress component + styling + tests

* formating with prettier

* using existing note component

* upload script (#10086)

* Bulk-Edit-App: Adding progress note in undo update [INTEG-3112] (#10087)

* Adding progress note in undo update

* Update apps/bulk-edit/src/locations/Page/components/UndoBulkEditModal.tsx

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>
Co-authored-by: Copilot <[email protected]>
JuliRossi pushed a commit that referenced this pull request Sep 2, 2025
* freeze top row with Field Names

* removing unused import
FBanfi added a commit that referenced this pull request Sep 2, 2025
* freeze top row with Field Names

* removing unused import
FBanfi added a commit that referenced this pull request Sep 2, 2025
…EG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting
FBanfi added a commit that referenced this pull request Sep 3, 2025
* freeze top row with Field Names

* removing unused import
JuliRossi added a commit that referenced this pull request Sep 3, 2025
* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>
ryunsong-contentful pushed a commit that referenced this pull request Sep 3, 2025
* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* Bulk-Edit-App: Changing the spinner for a skeleton [INTEG-3104] (#10081)

* changing the spinner for a skeleton

* rename css style

* making the status column sticky too (#10082)

* Bulk edit [INTEG-2847] (#10074)

* Enhance performance and reduce errors by batching

* Adding create-entries and delete-entries v1 scripts

* Fixing cors size limitation

* moving scripts

* Minor fixes

* Tests and refactor

* Update .env.example to clarify optional entry count setting

* Fixing truncation for some really big texts

* Adding delete-entries modifications and tests

* generation with numbers of entries

* batching for getting large entries

* simplifying a bit

* disabling cancel botton when undoing and saving

* Set truncate to 30

* Fixing config files

* making test better and simpler

* remove duplication

* making adjustments base on comments

* Refactor entry fetching to handle batch sizes and improve response limits

---------

Co-authored-by: francobanfi <[email protected]>

* Bulk-Edit-App: Show the progress of the edition [INTEG-3106] (#10085)

* adding progress in modal and tests

* formating with prettier

* creating generic progress component + styling + tests

* formating with prettier

* using existing note component

* upload script (#10086)

* Bulk-Edit-App: Adding progress note in undo update [INTEG-3112] (#10087)

* Adding progress note in undo update

* Update apps/bulk-edit/src/locations/Page/components/UndoBulkEditModal.tsx

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>
Co-authored-by: Copilot <[email protected]>
JuliRossi added a commit that referenced this pull request Sep 4, 2025
* Bulk-Edit-App: Fix sorting error and edit button with no padding [INTEG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting

* Bulk edit: Filter columns [INTEG-3089] (#10089)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* fixing view numbers (#10092)

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>
JuliRossi pushed a commit that referenced this pull request Sep 11, 2025
…EG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting
JuliRossi added a commit that referenced this pull request Sep 11, 2025
* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>
JuliRossi pushed a commit that referenced this pull request Sep 17, 2025
…EG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting
JuliRossi added a commit that referenced this pull request Sep 17, 2025
* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>
JuliRossi added a commit that referenced this pull request Sep 17, 2025
* Bulk-Edit-App: Fix sorting error and edit button with no padding [INTEG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting

* Bulk edit: Filter columns [INTEG-3089] (#10089)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* wip

* Added new useKeyboardNavigation hook to encapsulate keyboard navigation logic.

* Simplifying a bit

* Refactor keyboard navigation logic in useKeyboardNavigation hook for improved readability and performance. Simplified moveFocus and extendFocusToEdge functions by removing unnecessary useCallback and enhancing selection handling.

* Refactor EntryTable and TableHeader components to improve keyboard navigation and selection handling. Updated focus logic to use HEADERS_ROW constant for better readability and maintainability. Enhanced checkbox toggle functionality for header and row selections.

* fixing issues

* changing styles for keyboard accessibility

* Refactors and tests

* Fixing focus on first cell and edge navigation

* Readding column selection

* Refactoring styles

* Refactor Table components to centralize cell focus and selection logic.

* Fixing checked disable checkboxes

* Refactor EntryTable, TableHeader, and TableRow components to unify cell focus and selection logic. Updated function signatures to use FocusPosition for better clarity and maintainability. Enhanced keyboard navigation handling in useKeyboardNavigation hook and corresponding tests.

* Simplifying a few things. Enter doesn't do that much anymore

* fix merge

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>
JuliRossi added a commit that referenced this pull request Sep 25, 2025
* Bulk-Edit-App: Fix sorting error and edit button with no padding [INTEG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting

* Bulk edit: Filter columns [INTEG-3089] (#10089)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* wip

* Added new useKeyboardNavigation hook to encapsulate keyboard navigation logic.

* Simplifying a bit

* Refactor keyboard navigation logic in useKeyboardNavigation hook for improved readability and performance. Simplified moveFocus and extendFocusToEdge functions by removing unnecessary useCallback and enhancing selection handling.

* Refactor EntryTable and TableHeader components to improve keyboard navigation and selection handling. Updated focus logic to use HEADERS_ROW constant for better readability and maintainability. Enhanced checkbox toggle functionality for header and row selections.

* fixing issues

* changing styles for keyboard accessibility

* Refactors and tests

* Fixing focus on first cell and edge navigation

* Readding column selection

* Refactoring styles

* Refactor Table components to centralize cell focus and selection logic.

* Fixing checked disable checkboxes

* Refactor EntryTable, TableHeader, and TableRow components to unify cell focus and selection logic. Updated function signatures to use FocusPosition for better clarity and maintainability. Enhanced keyboard navigation handling in useKeyboardNavigation hook and corresponding tests.

* Simplifying a few things. Enter doesn't do that much anymore

* fix merge

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>
JuliRossi added a commit that referenced this pull request Oct 21, 2025
* Keyboard accesibility for bulk edit [MAPS-29] (#10110)

* Bulk-Edit-App: Fix sorting error and edit button with no padding [INTEG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting

* Bulk edit: Filter columns [INTEG-3089] (#10089)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* wip

* Added new useKeyboardNavigation hook to encapsulate keyboard navigation logic.

* Simplifying a bit

* Refactor keyboard navigation logic in useKeyboardNavigation hook for improved readability and performance. Simplified moveFocus and extendFocusToEdge functions by removing unnecessary useCallback and enhancing selection handling.

* Refactor EntryTable and TableHeader components to improve keyboard navigation and selection handling. Updated focus logic to use HEADERS_ROW constant for better readability and maintainability. Enhanced checkbox toggle functionality for header and row selections.

* fixing issues

* changing styles for keyboard accessibility

* Refactors and tests

* Fixing focus on first cell and edge navigation

* Readding column selection

* Refactoring styles

* Refactor Table components to centralize cell focus and selection logic.

* Fixing checked disable checkboxes

* Refactor EntryTable, TableHeader, and TableRow components to unify cell focus and selection logic. Updated function signatures to use FocusPosition for better clarity and maintainability. Enhanced keyboard navigation handling in useKeyboardNavigation hook and corresponding tests.

* Simplifying a few things. Enter doesn't do that much anymore

* fix merge

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* Tooltip fix for bulk edit [MAPS-57] (#10148)

* fix

* wip

* Workaround to make both things work

* disabling filter when entries are loading (#10150)

* Bulk Edit: Improved performance [MAPS-72] (#10163)

* Scroll when navigating with keyboard

* Add virtual scrolling

* Adjust styles

---------

Co-authored-by: JuliRossi <[email protected]>
Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>
FBanfi added a commit that referenced this pull request Oct 21, 2025
* Bulk-Edit-App: Fix sorting error and edit button with no padding [INTEG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting

* Bulk edit: Filter columns [INTEG-3089] (#10089)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* wip

* Added new useKeyboardNavigation hook to encapsulate keyboard navigation logic.

* Simplifying a bit

* Refactor keyboard navigation logic in useKeyboardNavigation hook for improved readability and performance. Simplified moveFocus and extendFocusToEdge functions by removing unnecessary useCallback and enhancing selection handling.

* Refactor EntryTable and TableHeader components to improve keyboard navigation and selection handling. Updated focus logic to use HEADERS_ROW constant for better readability and maintainability. Enhanced checkbox toggle functionality for header and row selections.

* fixing issues

* changing styles for keyboard accessibility

* Refactors and tests

* Fixing focus on first cell and edge navigation

* Readding column selection

* Refactoring styles

* Refactor Table components to centralize cell focus and selection logic.

* Fixing checked disable checkboxes

* Refactor EntryTable, TableHeader, and TableRow components to unify cell focus and selection logic. Updated function signatures to use FocusPosition for better clarity and maintainability. Enhanced keyboard navigation handling in useKeyboardNavigation hook and corresponding tests.

* Simplifying a few things. Enter doesn't do that much anymore

* fix merge

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>
FBanfi added a commit that referenced this pull request Oct 21, 2025
* Bulk-Edit-App: Fix sorting error and edit button with no padding [INTEG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting

* Bulk edit: Filter columns [INTEG-3089] (#10089)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* wip

* Added new useKeyboardNavigation hook to encapsulate keyboard navigation logic.

* Simplifying a bit

* Refactor keyboard navigation logic in useKeyboardNavigation hook for improved readability and performance. Simplified moveFocus and extendFocusToEdge functions by removing unnecessary useCallback and enhancing selection handling.

* Refactor EntryTable and TableHeader components to improve keyboard navigation and selection handling. Updated focus logic to use HEADERS_ROW constant for better readability and maintainability. Enhanced checkbox toggle functionality for header and row selections.

* fixing issues

* changing styles for keyboard accessibility

* Refactors and tests

* Fixing focus on first cell and edge navigation

* Readding column selection

* Refactoring styles

* Refactor Table components to centralize cell focus and selection logic.

* Fixing checked disable checkboxes

* Refactor EntryTable, TableHeader, and TableRow components to unify cell focus and selection logic. Updated function signatures to use FocusPosition for better clarity and maintainability. Enhanced keyboard navigation handling in useKeyboardNavigation hook and corresponding tests.

* Simplifying a few things. Enter doesn't do that much anymore

* fix merge

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>
FBanfi added a commit that referenced this pull request Oct 21, 2025
)

* Keyboard accesibility for bulk edit [MAPS-29] (#10110)

* Bulk-Edit-App: Fix sorting error and edit button with no padding [INTEG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting

* Bulk edit: Filter columns [INTEG-3089] (#10089)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* wip

* Added new useKeyboardNavigation hook to encapsulate keyboard navigation logic.

* Simplifying a bit

* Refactor keyboard navigation logic in useKeyboardNavigation hook for improved readability and performance. Simplified moveFocus and extendFocusToEdge functions by removing unnecessary useCallback and enhancing selection handling.

* Refactor EntryTable and TableHeader components to improve keyboard navigation and selection handling. Updated focus logic to use HEADERS_ROW constant for better readability and maintainability. Enhanced checkbox toggle functionality for header and row selections.

* fixing issues

* changing styles for keyboard accessibility

* Refactors and tests

* Fixing focus on first cell and edge navigation

* Readding column selection

* Refactoring styles

* Refactor Table components to centralize cell focus and selection logic.

* Fixing checked disable checkboxes

* Refactor EntryTable, TableHeader, and TableRow components to unify cell focus and selection logic. Updated function signatures to use FocusPosition for better clarity and maintainability. Enhanced keyboard navigation handling in useKeyboardNavigation hook and corresponding tests.

* Simplifying a few things. Enter doesn't do that much anymore

* fix merge

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* Tooltip fix for bulk edit [MAPS-57] (#10148)

* fix

* wip

* Workaround to make both things work

* adding more field editors

* adding test for entry utils content type mapper

* refactors + removing createLocales

* parsing the value for the different editors

* setting truncation to display fields

* adding more tests

* pr comments

* format changes between conflicts resolution

* changing utils file name

---------

Co-authored-by: JuliRossi <[email protected]>
FBanfi added a commit that referenced this pull request Oct 21, 2025
…10159)

* Keyboard accesibility for bulk edit [MAPS-29] (#10110)

* Bulk-Edit-App: Fix sorting error and edit button with no padding [INTEG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting

* Bulk edit: Filter columns [INTEG-3089] (#10089)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* wip

* Added new useKeyboardNavigation hook to encapsulate keyboard navigation logic.

* Simplifying a bit

* Refactor keyboard navigation logic in useKeyboardNavigation hook for improved readability and performance. Simplified moveFocus and extendFocusToEdge functions by removing unnecessary useCallback and enhancing selection handling.

* Refactor EntryTable and TableHeader components to improve keyboard navigation and selection handling. Updated focus logic to use HEADERS_ROW constant for better readability and maintainability. Enhanced checkbox toggle functionality for header and row selections.

* fixing issues

* changing styles for keyboard accessibility

* Refactors and tests

* Fixing focus on first cell and edge navigation

* Readding column selection

* Refactoring styles

* Refactor Table components to centralize cell focus and selection logic.

* Fixing checked disable checkboxes

* Refactor EntryTable, TableHeader, and TableRow components to unify cell focus and selection logic. Updated function signatures to use FocusPosition for better clarity and maintainability. Enhanced keyboard navigation handling in useKeyboardNavigation hook and corresponding tests.

* Simplifying a few things. Enter doesn't do that much anymore

* fix merge

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* Tooltip fix for bulk edit [MAPS-57] (#10148)

* fix

* wip

* Workaround to make both things work

* changing some icons to match field editors versions + adding initial editors

* changing icon + modifying tests

* adding tests for FieldEditor component

* adding more field editors

* adding test for entry utils content type mapper

* renaming method

* removing unused variable

* moving methods to entry utils file

* removing any

* removing unnecessary logic for field editor setter

* changing disabled logic

* refactors + removing createLocales

* using field locale instead of default

* removing manual numeric validations

* removing mock from BulkEditModal.test.tsx

* fixing tests between conflicts

* Bulk-Edit: Parsing the value for the different editors [MAPS-53] (#10173)

* Keyboard accesibility for bulk edit [MAPS-29] (#10110)

* Bulk-Edit-App: Fix sorting error and edit button with no padding [INTEG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting

* Bulk edit: Filter columns [INTEG-3089] (#10089)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* wip

* Added new useKeyboardNavigation hook to encapsulate keyboard navigation logic.

* Simplifying a bit

* Refactor keyboard navigation logic in useKeyboardNavigation hook for improved readability and performance. Simplified moveFocus and extendFocusToEdge functions by removing unnecessary useCallback and enhancing selection handling.

* Refactor EntryTable and TableHeader components to improve keyboard navigation and selection handling. Updated focus logic to use HEADERS_ROW constant for better readability and maintainability. Enhanced checkbox toggle functionality for header and row selections.

* fixing issues

* changing styles for keyboard accessibility

* Refactors and tests

* Fixing focus on first cell and edge navigation

* Readding column selection

* Refactoring styles

* Refactor Table components to centralize cell focus and selection logic.

* Fixing checked disable checkboxes

* Refactor EntryTable, TableHeader, and TableRow components to unify cell focus and selection logic. Updated function signatures to use FocusPosition for better clarity and maintainability. Enhanced keyboard navigation handling in useKeyboardNavigation hook and corresponding tests.

* Simplifying a few things. Enter doesn't do that much anymore

* fix merge

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* Tooltip fix for bulk edit [MAPS-57] (#10148)

* fix

* wip

* Workaround to make both things work

* adding more field editors

* adding test for entry utils content type mapper

* refactors + removing createLocales

* parsing the value for the different editors

* setting truncation to display fields

* adding more tests

* pr comments

* format changes between conflicts resolution

* changing utils file name

---------

Co-authored-by: JuliRossi <[email protected]>

---------

Co-authored-by: JuliRossi <[email protected]>
joaquincasal added a commit that referenced this pull request Nov 11, 2025
* Bulk-Edit: field editors for initial default appearances [MAPS-53] (#10159)

* Keyboard accesibility for bulk edit [MAPS-29] (#10110)

* Bulk-Edit-App: Fix sorting error and edit button with no padding [INTEG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting

* Bulk edit: Filter columns [INTEG-3089] (#10089)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* wip

* Added new useKeyboardNavigation hook to encapsulate keyboard navigation logic.

* Simplifying a bit

* Refactor keyboard navigation logic in useKeyboardNavigation hook for improved readability and performance. Simplified moveFocus and extendFocusToEdge functions by removing unnecessary useCallback and enhancing selection handling.

* Refactor EntryTable and TableHeader components to improve keyboard navigation and selection handling. Updated focus logic to use HEADERS_ROW constant for better readability and maintainability. Enhanced checkbox toggle functionality for header and row selections.

* fixing issues

* changing styles for keyboard accessibility

* Refactors and tests

* Fixing focus on first cell and edge navigation

* Readding column selection

* Refactoring styles

* Refactor Table components to centralize cell focus and selection logic.

* Fixing checked disable checkboxes

* Refactor EntryTable, TableHeader, and TableRow components to unify cell focus and selection logic. Updated function signatures to use FocusPosition for better clarity and maintainability. Enhanced keyboard navigation handling in useKeyboardNavigation hook and corresponding tests.

* Simplifying a few things. Enter doesn't do that much anymore

* fix merge

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* Tooltip fix for bulk edit [MAPS-57] (#10148)

* fix

* wip

* Workaround to make both things work

* changing some icons to match field editors versions + adding initial editors

* changing icon + modifying tests

* adding tests for FieldEditor component

* adding more field editors

* adding test for entry utils content type mapper

* renaming method

* removing unused variable

* moving methods to entry utils file

* removing any

* removing unnecessary logic for field editor setter

* changing disabled logic

* refactors + removing createLocales

* using field locale instead of default

* removing manual numeric validations

* removing mock from BulkEditModal.test.tsx

* fixing tests between conflicts

* Bulk-Edit: Parsing the value for the different editors [MAPS-53] (#10173)

* Keyboard accesibility for bulk edit [MAPS-29] (#10110)

* Bulk-Edit-App: Fix sorting error and edit button with no padding [INTEG-3103] (#10090)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* not showing the edit button when loading entries

* fix error when changing sorting

* Bulk edit: Filter columns [INTEG-3089] (#10089)

* Bulk-Edit-App: Freeze top row with Field Names [INTEG-2953] (#10076)

* freeze top row with Field Names

* removing unused import

* making the status column sticky too (#10082)

* wip

* select all

* Refactor FilterColumns and SortMenu components for improved layout and functionality

* Fixing states and enhancing performance in the process by not calling the getContentType each time

* Fix box issue

* Renaming and fixing warnings

* sticky

* corrections PR comments

* Fixing rebase conflicts

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* wip

* Added new useKeyboardNavigation hook to encapsulate keyboard navigation logic.

* Simplifying a bit

* Refactor keyboard navigation logic in useKeyboardNavigation hook for improved readability and performance. Simplified moveFocus and extendFocusToEdge functions by removing unnecessary useCallback and enhancing selection handling.

* Refactor EntryTable and TableHeader components to improve keyboard navigation and selection handling. Updated focus logic to use HEADERS_ROW constant for better readability and maintainability. Enhanced checkbox toggle functionality for header and row selections.

* fixing issues

* changing styles for keyboard accessibility

* Refactors and tests

* Fixing focus on first cell and edge navigation

* Readding column selection

* Refactoring styles

* Refactor Table components to centralize cell focus and selection logic.

* Fixing checked disable checkboxes

* Refactor EntryTable, TableHeader, and TableRow components to unify cell focus and selection logic. Updated function signatures to use FocusPosition for better clarity and maintainability. Enhanced keyboard navigation handling in useKeyboardNavigation hook and corresponding tests.

* Simplifying a few things. Enter doesn't do that much anymore

* fix merge

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: francobanfi <[email protected]>

* Tooltip fix for bulk edit [MAPS-57] (#10148)

* fix

* wip

* Workaround to make both things work

* adding more field editors

* adding test for entry utils content type mapper

* refactors + removing createLocales

* parsing the value for the different editors

* setting truncation to display fields

* adding more tests

* pr comments

* format changes between conflicts resolution

* changing utils file name

---------

Co-authored-by: JuliRossi <[email protected]>

---------

Co-authored-by: JuliRossi <[email protected]>

* Bulk edit: Refactor display names [MAPS-78] (#10205)

* refactor to reuse existing display value method

* refactor for getFieldDisplayValue method

* refactor in the getEntryFieldValue method

* removing test

* Bulk Edit: Customize the Boolean editor label with user settings [MAPS-86] (#10210)

* first version of the customizable boolean labels

* refactor to use useSdk hook

* adding tests and some refactors

* fixing pr comments

* removing unused imports

* Bulk Edit: Alternative appearances [MAPS-54] (#10219)

* first version of the customizable boolean labels

* refactor to use useSdk hook

* fixing pr comments

* removing unused imports

* adding alternative appearances for field editors

* Bulk edit: Add field validations [MAPS-52] (#10221)

* Add field validations

* Address PR comments

- Remove duplicated debounced value
- Updated the way error messages are displayed so they're consistent with errors from the field editors
- Removed redundant isValid property

* Bulk edit v2 fixes [MAPS-22] (#10229)

* Run validations for items

* Remove value from update if empty

---------

Co-authored-by: Franco Banfi <[email protected]>
Co-authored-by: JuliRossi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants