Skip to content

Conversation

@JuliRossi
Copy link
Collaborator

@JuliRossi JuliRossi commented Oct 27, 2025

Purpose

We want to use modern app actions parameterSchema and resultSchema for the slack app action.

Approach

  • Updated the readme with information to update the dockerfile and serveless node version to 18 to be able to run it locally
  • Added manifest to slack app
  • Add script to upsert actions from manifest
  • Modify the controller => Now it returns what the post actually returns

Did some clean up:

  • Updated some necessary deps
  • Fixed some old tests that were failing =>
    - When running all tests, a controller and repository were having conflicts because we didn't restore the mock.
    - Controller type issue with undefined values

Testing steps

As the app action is only used in Workflows, I created a button to run the action with the new format . This video shows that aproach. We also updated the controller tests
What errors look like:

What it correctly working looks like (this response is only showing blocks so we don't show any ids)

Grabacion.de.pantalla.2025-10-27.a.la.s.4.53.44.p.m.mov

Showing how the script works updating actions

Grabacion.de.pantalla.2025-10-27.a.la.s.5.16.11.p.m.mov

Showing how it works creating actions:

Grabacion.de.pantalla.2025-10-27.a.la.s.5.03.12.p.m.mov

@wiz-inc-38d59fb8d7
Copy link

wiz-inc-38d59fb8d7 bot commented Oct 27, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Total -

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@JuliRossi JuliRossi marked this pull request as ready for review October 27, 2025 20:21
@JuliRossi JuliRossi requested a review from a team as a code owner October 27, 2025 20:21
Copy link
Contributor

@ryunsong-contentful ryunsong-contentful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some light testing with the slack app and still works.

Nice job

@JuliRossi JuliRossi merged commit 3b72a13 into master Oct 29, 2025
18 checks passed
@JuliRossi JuliRossi deleted the add-manifest-to-slack branch October 29, 2025 19:04
JuliRossi added a commit that referenced this pull request Oct 29, 2025
JuliRossi added a commit that referenced this pull request Oct 29, 2025
@JuliRossi JuliRossi restored the add-manifest-to-slack branch October 30, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants