-
Notifications
You must be signed in to change notification settings - Fork 166
feat: google docs doc uploader [INTEG-3258] #10250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: google docs doc uploader [INTEG-3258] #10250
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
…as HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
| // Simulate progress to 100% over ~1.5s | ||
| await new Promise<void>((resolve) => { | ||
| const start = Date.now(); | ||
| const tick = () => { | ||
| const elapsed = Date.now() - start; | ||
| const percent = Math.min(100, Math.round((elapsed / 1500) * 100)); | ||
| setUploadProgress(percent); | ||
| if (percent >= 100) { | ||
| resolve(); | ||
| } else { | ||
| requestAnimationFrame(tick); | ||
| } | ||
| }; | ||
| requestAnimationFrame(tick); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is just for us and throw away work, probably doesn't make much sense to have this part. thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind keeping it
harikakondur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm !!
ryunsong-contentful
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid overall, can you provide both the html and json view when hitting the google drive api. Also the next iteration will be just having the link as a request param into the backend and the backend will actually perform the call to google drive api.
Let me know if you have questions
Purpose
This is throw away work. We needed a way to load google docs but this solution is not part of the final designs
Approach
Testing steps
Breaking Changes
Dependencies and/or References
Deployment