Skip to content

Conversation

@david-shibley-contentful
Copy link
Contributor

@david-shibley-contentful david-shibley-contentful commented Nov 13, 2025

Purpose

This is throw away work. We needed a way to load google docs but this solution is not part of the final designs

Approach

Screenshot 2025-11-13 at 1 28 42 PM

Testing steps

Breaking Changes

Dependencies and/or References

Deployment

@david-shibley-contentful david-shibley-contentful requested a review from a team as a code owner November 13, 2025 18:29
@wiz-inc-38d59fb8d7
Copy link

wiz-inc-38d59fb8d7 bot commented Nov 13, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
SAST Finding SAST Findings 1 Medium
Total 1 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

…as HTML

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@david-shibley-contentful david-shibley-contentful changed the title feat: google docs doc uploader feat: google docs doc uploader [INTEG-3271] Nov 13, 2025
@david-shibley-contentful david-shibley-contentful changed the title feat: google docs doc uploader [INTEG-3271] feat: google docs doc uploader [INTEG-3258] Nov 13, 2025
Comment on lines +77 to +91
// Simulate progress to 100% over ~1.5s
await new Promise<void>((resolve) => {
const start = Date.now();
const tick = () => {
const elapsed = Date.now() - start;
const percent = Math.min(100, Math.round((elapsed / 1500) * 100));
setUploadProgress(percent);
if (percent >= 100) {
resolve();
} else {
requestAnimationFrame(tick);
}
};
requestAnimationFrame(tick);
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is just for us and throw away work, probably doesn't make much sense to have this part. thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind keeping it

Copy link
Contributor

@harikakondur harikakondur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !!

Copy link
Contributor

@ryunsong-contentful ryunsong-contentful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid overall, can you provide both the html and json view when hitting the google drive api. Also the next iteration will be just having the link as a request param into the backend and the backend will actually perform the call to google drive api.

Let me know if you have questions

@david-shibley-contentful david-shibley-contentful merged commit 870933a into master Nov 14, 2025
14 checks passed
@david-shibley-contentful david-shibley-contentful deleted the feat/google-docs-doc-uploader branch November 14, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants