fix: adopt new batch-lib version [NONE]#950
Open
Marco Link (marcolink) wants to merge 2 commits intomainfrom
Open
fix: adopt new batch-lib version [NONE]#950Marco Link (marcolink) wants to merge 2 commits intomainfrom
Marco Link (marcolink) wants to merge 2 commits intomainfrom
Conversation
Marco Link (marcolink)
force-pushed
the
feat/adopt-new-batch-libs-version
branch
from
35f5640 to
2d308c7
Compare
Contributor
Brad Turner (Brad-Turner)
left a comment
Brad Turner (Brad-Turner)
left a comment
There was a problem hiding this comment.
Looks good to me. Would be nice to reduce the reliance on lodash 🤔
| const errorLog = log.filter((logMessage) => logMessage.level !== 'info' && logMessage.level !== 'warning') | ||
| const displayLog = log.filter((logMessage) => logMessage.level !== 'info') | ||
| const errorLog = log.filter(isErrorLog) | ||
| const displayLog = log.filter(isDisplayLog) |
Contributor
There was a problem hiding this comment.
log only accepts messages with levels error or warn, I think this filter does nothing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align with the changes from the new major version contentful-batch-libs@10
cc Brad Turner (@Brad-Turner)