feat: add support for locale based publishing [TOL-2810]#1465
Merged
Chris Helgert (chrishelgert) merged 5 commits intomainfrom Feb 21, 2025
Merged
feat: add support for locale based publishing [TOL-2810]#1465Chris Helgert (chrishelgert) merged 5 commits intomainfrom
Chris Helgert (chrishelgert) merged 5 commits intomainfrom
Conversation
Marco Link (marcolink)
approved these changes
Feb 20, 2025
Member
Marco Link (marcolink)
left a comment
Marco Link (marcolink)
left a comment
There was a problem hiding this comment.
I don't fully understand the * key, but it generally looks good :)
Jared Jolton (jjolton-contentful)
approved these changes
Feb 20, 2025
Contributor
Jared Jolton (jjolton-contentful)
left a comment
Jared Jolton (jjolton-contentful)
left a comment
There was a problem hiding this comment.
Fantastic work on this, I know quite a few devs are going to be so excited to see this land!!
The publishing steps in both entry transformation and derivation are pretty similar, extracting the logic (or at least the locale extraction part) into a shared helper might reduce duplication and simplify maintenance, but that is just a nitpick and is absolutely not necessary for this changeset.
|
🎉 This PR is included in version 4.28.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support for using locale-based publishing is added to keep the status more granular.
Kapture.2025-02-20.at.16.43.54.mp4