feat: reintroducing table cell schema changes [TOL-2249] by aodhagan-cf · Pull Request #622 · contentful/rich-text

Aodhagan Murphy (aodhagan-cf) · 2024-07-19T09:49:31Z

Decoupling table header cell and data cell blocks
Following pattern that list item blocks use

contentful-automation · 2024-07-19T10:42:24Z

Size Change: 0 B

Total Size: 251 kB

ℹ️ View Unchanged

Filename	Size	Change
`./packages/contentful-slatejs-adapter/dist/contentful-slatejs-adapter.es5.js`	2.48 kB	0 B
`./packages/contentful-slatejs-adapter/dist/lib/__test__/contentful-helpers.js`	344 B	0 B
`./packages/contentful-slatejs-adapter/dist/lib/__test__/contentful-to-slatejs-adapter.test.js`	2.09 kB	0 B
`./packages/contentful-slatejs-adapter/dist/lib/contentful-to-slatejs-adapter.js`	858 B	0 B
`./packages/contentful-slatejs-adapter/dist/lib/helpers.js`	156 B	0 B
`./packages/contentful-slatejs-adapter/dist/lib/index.js`	142 B	0 B
`./packages/contentful-slatejs-adapter/dist/lib/schema.js`	516 B	0 B
`./packages/contentful-slatejs-adapter/dist/lib/slatejs-to-contentful-adapter.js`	1.02 kB	0 B
`./packages/contentful-slatejs-adapter/dist/lib/types/index.js`	64 B	0 B
`./packages/contentful-slatejs-adapter/dist/lib/types/slate.js`	88 B	0 B
`./packages/rich-text-from-markdown/dist/lib/__test__/helpers.js`	620 B	0 B
`./packages/rich-text-from-markdown/dist/lib/__test__/index.test.js`	2.36 kB	0 B
`./packages/rich-text-from-markdown/dist/lib/__test__/real-world.test.js`	2.6 kB	0 B
`./packages/rich-text-from-markdown/dist/lib/index.js`	3.97 kB	0 B
`./packages/rich-text-from-markdown/dist/lib/types/index.js`	125 B	0 B
`./packages/rich-text-from-markdown/dist/rich-text-from-es5.js`	182 kB	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/embedded-entry.js`	309 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/embedded-js`	316 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/heading.js`	320 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/hr.js`	258 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/hyperlink.js`	311 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/index.js`	602 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/inline-entity.js`	377 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/invalid-marks.js`	284 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/invalid-type.js`	316 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/mark.js`	274 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/ol.js`	320 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/paragraph.js`	245 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/quote.js`	257 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/table-header.js`	412 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/table.js`	401 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/documents/ul.js`	321 B	0 B
`./packages/rich-text-html-renderer/dist/lib/__test__/index.test.js`	2.21 kB	0 B
`./packages/rich-text-html-renderer/dist/lib/index.js`	1.77 kB	0 B
`./packages/rich-text-html-renderer/dist/rich-text-html-es5.js`	5.52 kB	0 B
`./packages/rich-text-links/dist/lib/__test__/index.test.js`	2.19 kB	0 B
`./packages/rich-text-links/dist/lib/index.js`	1.62 kB	0 B
`./packages/rich-text-links/dist/lib/types/utils.js`	124 B	0 B
`./packages/rich-text-links/dist/rich-text-links.es5.js`	4.41 kB	0 B
`./packages/rich-text-plain-text-renderer/dist/lib/__test__/index.test.js`	955 B	0 B
`./packages/rich-text-plain-text-renderer/dist/lib/index.js`	1.27 kB	0 B
`./packages/rich-text-plain-text-renderer/dist/rich-text-plain-text-es5.js`	4.07 kB	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/components/js`	287 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/components/Paragraph.js`	287 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/components/Strong.js`	287 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/embedded-entry.js`	309 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/embedded-js`	316 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/heading.js`	320 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/hr.js`	258 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/hyperlink.js`	311 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/index.js`	662 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/inline-entity.js`	377 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/invalid-marks.js`	284 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/invalid-type.js`	316 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/mark.js`	274 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/multi-mark.js`	289 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/ol.js`	320 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/paragraph.js`	245 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/quote.js`	257 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/table-header.js`	412 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/table.js`	401 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/documents/ul.js`	321 B	0 B
`./packages/rich-text-react-renderer/dist/lib/__test__/index.test.js`	2.75 kB	0 B
`./packages/rich-text-react-renderer/dist/lib/index.js`	1.27 kB	0 B
`./packages/rich-text-react-renderer/dist/lib/util/appendKeyToValidElement.js`	259 B	0 B
`./packages/rich-text-react-renderer/dist/lib/util/nodeListToReactComponents.js`	843 B	0 B
`./packages/rich-text-react-renderer/dist/rich-text-react-es5.js`	4.98 kB	0 B
`./packages/rich-text-types/dist/__test__/schemaConstraints.test.js`	686 B	0 B
`./packages/rich-text-types/dist/blocks.js`	487 B	0 B
`./packages/rich-text-types/dist/emptyDocument.js`	356 B	0 B
`./packages/rich-text-types/dist/helpers.js`	475 B	0 B
`./packages/rich-text-types/dist/index.js`	802 B	0 B
`./packages/rich-text-types/dist/inlines.js`	460 B	0 B
`./packages/rich-text-types/dist/marks.js`	317 B	0 B
`./packages/rich-text-types/dist/nodeTypes.js`	127 B	0 B
`./packages/rich-text-types/dist/schemaConstraints.js`	1.09 kB	0 B
`./packages/rich-text-types/dist/schemas/__test__/helpers.test.js`	368 B	0 B
`./packages/rich-text-types/dist/schemas/__test__/schemas.test.js`	425 B	0 B
`./packages/rich-text-types/dist/schemas/index.js`	263 B	0 B
`./packages/rich-text-types/dist/types.js`	124 B	0 B

packages/rich-text-types/src/nodeTypes.ts

…OL-2249]

z0al · 2024-07-23T16:27:16Z

packages/rich-text-types/src/schemaConstraints.ts

 export type TableRowBlockEnum = BLOCKS.TABLE_CELL | BLOCKS.TABLE_HEADER_CELL;

-export type TableCellEnum = BLOCKS.PARAGRAPH | BLOCKS.UL_LIST | BLOCKS.OL_LIST;
+export type TableCellEnum = ListItemBlockEnum;


Nit: Can we have a dedicated enum here? it would be handy when adjusting the normalisation logic in the editor

You also need to adjust the entry for table cell in the CONTAINERS below

Kudakwashe Mupeni (2wce) and others added 6 commits July 19, 2024 10:45

feat: update schema for rich text types

c6f2380

chore: update snapshots

6617c21

chore: update schema

36cced0

chore: update snapshots

a366d2c

chore: update table cell nodetype

73eb553

feat: adjusting table cell/header schemas [TOL-2249]

b3f4bd2

github-actions bot added the package:rich-text-types label Jul 19, 2024

feat: adding comment to explain reason for coupling [TOL-2249]

0cacfdf

Aodhagan Murphy (aodhagan-cf) commented Jul 19, 2024

View reviewed changes

packages/rich-text-types/src/nodeTypes.ts Outdated Show resolved Hide resolved

Aodhagan Murphy (aodhagan-cf) added 2 commits July 19, 2024 13:05

chore: adjusting table schema [TOL-2249]

e4eeae2

chore: updating snapshot tests [TOL-2249]

3d02a7d

Aodhagan Murphy (aodhagan-cf) requested a review from a team July 19, 2024 12:38

Aodhagan Murphy (aodhagan-cf) marked this pull request as ready for review July 19, 2024 12:41

chore: updating comment [TOL-2249]

7b248ab

z0al requested changes Jul 19, 2024

View reviewed changes

packages/rich-text-types/src/nodeTypes.ts Outdated Show resolved Hide resolved

chore: adjusting table blocks schemas to follow list block pattern [T…

e5ea016

…OL-2249]

z0al approved these changes Jul 22, 2024

View reviewed changes

Aodhagan Murphy (aodhagan-cf) added 2 commits July 23, 2024 14:17

chore: adding same rules as list item for table cell [TOL-2249]

12c40df

chore: updating snapshots [TOL-2249]

6b3ea05

z0al reviewed Jul 23, 2024

View reviewed changes

Merge branch 'master' into feat/TOL-2249

3ec95ae

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: reintroducing table cell schema changes [TOL-2249]#622

feat: reintroducing table cell schema changes [TOL-2249]#622
Aodhagan Murphy (aodhagan-cf) wants to merge 14 commits intomasterfrom
feat/TOL-2249

Aodhagan Murphy (aodhagan-cf) commented Jul 19, 2024 •

edited

Loading

Uh oh!

contentful-automation bot commented Jul 19, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

z0al Jul 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Aodhagan Murphy (aodhagan-cf) commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

contentful-automation bot commented Jul 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

z0al Jul 23, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Aodhagan Murphy (aodhagan-cf) commented Jul 19, 2024 •

edited

Loading

contentful-automation bot commented Jul 19, 2024 •

edited

Loading