Feature/dropdown field choices #585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the content mapper flow in both the API and UI layers by introducing error handling, ensuring proper asynchronous behavior, and making response status codes dynamic.
- Added try-catch blocks and error propagation in the content mapper service.
- Fixed a missing await in the putTestData call for consistent asynchronous updates.
- Updated controller responses to use dynamic status codes instead of a static value.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| upload-api/src/services/contentful/index.ts | Updated axios response destructuring and validation of content_mapper. |
| upload-api/src/controllers/wordpress/index.ts | Replaced response handling via destructuring to determine dynamic status. |
| upload-api/src/controllers/sitecore/index.ts | Removed safe navigation from axios call and updated destructuring of response. |
| ui/src/components/DestinationStack/Actions/LoadLanguageMapper.tsx | Added state update callbacks to remove specific options from selection and updated deletion logic. |
| api/src/services/contentMapper.service.ts | Wrapped multiple service functions in try-catch blocks, fixed asynchronous writes, and returned dynamic status in responses. |
| api/src/controllers/projects.contentMapper.controller.ts | Updated controller responses to use dynamic status codes from the service layer. |
Comments suppressed due to low confidence (1)
ui/src/components/DestinationStack/Actions/LoadLanguageMapper.tsx:240
- [nitpick] The inline comment refers to 'csLocale' while the variable in use is 'locale'. Update the comment to accurately reflect the variable name.
(item) => item !== locale // Remove the item equal to csLocale
| getLogMessage( | ||
| srcFunc, | ||
| `${HTTP_TEXTS.CONTENT_TYPE_NOT_FOUND} Id: ${contentTypeId}` | ||
| "Error occurred while while getting field mapping of projects", |
There was a problem hiding this comment.
The error log message contains a duplicate 'while'. Removing one occurrence would improve clarity.
Suggested change
| "Error occurred while while getting field mapping of projects", | |
| "Error occurred while getting field mapping of projects", |
Contributor
Author
There was a problem hiding this comment.
resolved the comments
…r into feature/dropdown-field-choices
umeshmore45
pushed a commit
that referenced
this pull request
Jun 11, 2025
Feature/dropdown field choices
AishDani
pushed a commit
that referenced
this pull request
Jul 26, 2025
Feature/dropdown field choices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
++ added try-catch block in content mapper service of api
++ added missing await in putTestData call
++ removed static status code from content mapper controller and made it dynamic