Feature/cli optimise #598
Feature/cli optimise #598
Conversation
sauravraw
force-pushed
the
feature/cli-optimise
branch
from
4a0510d to
7cd75ad
Compare
There was a problem hiding this comment.
Copilot reviewed 847 out of 852 changed files in this pull request and generated no comments.
Files not reviewed (5)
- .vscode/extensions.json: Language not supported
- api/.gitignore: Language not supported
- api/package.json: Language not supported
- api/production.env: Language not supported
- api/tsconfig.json: Language not supported
Comments suppressed due to low confidence (1)
api/src/server.ts:127
- Consider renaming the parameter 'path' in the file watcher callback to avoid shadowing the imported 'path' module, for clarity.
watcher.on('change', async (path) => {
There was a problem hiding this comment.
Copilot reviewed 847 out of 852 changed files in this pull request and generated 1 comment.
Files not reviewed (5)
- .vscode/extensions.json: Language not supported
- api/.gitignore: Language not supported
- api/package.json: Language not supported
- api/production.env: Language not supported
- api/tsconfig.json: Language not supported
Comments suppressed due to low confidence (1)
api/src/utils/custom-logger.utils.ts:10
- Using startsWith for path validation could be error prone; replacing it with a check using path.relative would ensure that the resolved path truly resides within the basePath.
if (!resolvedPath.startsWith(basePath)) {
There was a problem hiding this comment.
Copilot reviewed 847 out of 852 changed files in this pull request and generated no comments.
Files not reviewed (5)
- .vscode/extensions.json: Language not supported
- api/.gitignore: Language not supported
- api/package.json: Language not supported
- api/production.env: Language not supported
- api/tsconfig.json: Language not supported
There was a problem hiding this comment.
Copilot reviewed 848 out of 853 changed files in this pull request and generated no comments.
Files not reviewed (5)
- .vscode/extensions.json: Language not supported
- api/.gitignore: Language not supported
- api/package.json: Language not supported
- api/production.env: Language not supported
- api/tsconfig.json: Language not supported
Comments suppressed due to low confidence (2)
api/src/validators/stack.validator.ts:14
- [nitpick] Consider adding a brief comment explaining the use of a global regex in error message replacement, to clarify its necessity compared to a single replacement.
errorMessage: VALIDATION_ERRORS.STRING_REQUIRED.replace(/\$/g, "Name"),
api/src/utils/custom-logger.utils.ts:25
- [nitpick] Review the directory containment check logic in safeJoin to ensure that all edge cases for preventing directory traversal are correctly handled. Adding inline comments to explain the rationale could improve maintainability.
if (relativePath === '' || relativePath === '.' || (!relativePath.startsWith('..') && !path.isAbsolute(relativePath))) {
…r into feature/cli-optimise
…r into feature/cli-optimise
…ion-v2-node-server into feature/cli-optimise
| setExistingField((prevExisting: ExistingFieldType) => { | ||
| const updatedExisting = { ...prevExisting }; | ||
| const validLabels = cmsLocaleOptions?.map(locale => locale.label) || []; | ||
| Object.entries(updatedExisting).forEach(([index, entry]) => { |
There was a problem hiding this comment.
const validLabels = cmsLocaleOptions?.map(locale => locale?.label) || [];
Object.entries(updatedExisting)?.forEach(([index, entry]) => {
| Object.entries(updatedExisting).forEach(([index, entry]) => { | ||
| const [labelPart] = entry.label.split('-'); | ||
| if (!validLabels.includes(labelPart)) { | ||
| delete updatedExisting[index]; |
There was a problem hiding this comment.
const [labelPart] = entry?.label?.split('-');
if (!validLabels?.includes(labelPart)) {
delete updatedExisting?.[index];
There was a problem hiding this comment.
entry?.label?.split('-'); adding validation to this gives error, added validation to other code
| Object.keys(updated).forEach((key) => { | ||
| const [labelPart] = key.split('-'); | ||
| if (!validLabels.includes(labelPart)) { | ||
| delete updated[key]; |
There was a problem hiding this comment.
Object.keys(updated)?.forEach((key) => {
const [labelPart] = key?.split('-');
if (!validLabels?.includes(labelPart)) {
delete updated?.[key];
| const isPresent = prevList.some( | ||
| (item: { label: string; value: string }) => item?.value === 'master_locale' | ||
| const isPresent = prevList.filter( |
|
|
||
| if (!isPresent) { | ||
|
|
||
| if(isPresent[0]?.label !== newLabel){ |
There was a problem hiding this comment.
if(isPresent?.[0]?.label !== newLabel){
No description provided.