Feature/execution log #664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented ExecutionLogs component to display migration logs with filtering options. - Created FilterModal for selecting log levels (info, error). - Integrated API call to fetch migration logs with pagination and filtering. - Updated Settings component to include Execution Logs section. - Added styles for ExecutionLogs and FilterModal components. - Defined TypeScript interfaces for log entries and filter options. - Enhanced user experience with loading states and no data messages.
…te to the previous migration step. - Updated ExecutionLogs component to improve error handling and user feedback with custom empty states. - Refactored filter modal styles .
…tionLogs component
…tate, css fix for empty state and dropdown
sayalijoshi27
requested changes
May 14, 2025
| const testStacks = useSelector( | ||
| (state: RootState) => state?.migration?.newMigrationData?.testStacks | ||
| ); | ||
| console.info(testStacks.length) |
| const [selectedStack, setSelectedStack] = useState<DropdownOption>( | ||
| { | ||
| label: stackIds[stackIds.length - 1]?.label ?? '' , | ||
| value: stackIds[stackIds.length - 1]?.value ?? '' |
Contributor
There was a problem hiding this comment.
It should be stackIds[stackIds?.length - 1]
| try { | ||
| let filterValueCopy: FilterOption[] = [...filterOption]; | ||
|
|
||
| if (!filterValueCopy.length && isChecked) { |
Contributor
There was a problem hiding this comment.
it should be filterValueCopy?.length
| } else if (isChecked) { | ||
| // Remove the old value and keep updated one in case old value exists | ||
| const updatedFilter = filterValueCopy.filter((v) => v.value !== value.value); | ||
| filterValueCopy = [...updatedFilter, value]; |
Contributor
There was a problem hiding this comment.
it should be
const updatedFilter = filterValueCopy?.filter((v) => v?.value !== value?.value);
| filterValueCopy = [...updatedFilter, value]; | ||
| } else if (!isChecked) { | ||
| filterValueCopy = filterValueCopy.filter((v) => v.value !== value.value); | ||
| } |
| // Method to handle Apply | ||
| const onApply = () => { | ||
| try { | ||
| if (!filterOption.length) { |
| return; | ||
| } | ||
|
|
||
| const usersQueryArray = filterOption.map((item) => item.value); |
Contributor
There was a problem hiding this comment.
filterOption?.map?((item) => item?.value);
| updateValue({ value: item, isChecked: e.target.checked }) | ||
| } | ||
| version="v2" | ||
| label={item.label} |
Contributor
There was a problem hiding this comment.
it should be item?.label. Please check whole file and added null checks
| <div className="tableFilterModalStories__suggestion-item"> | ||
| <Checkbox | ||
| checked={selectedLevels.some((v) => v.value === item.value)} | ||
| onChange={(e: React.ChangeEvent<HTMLInputElement>) => |
umeshmore45
requested changes
May 15, 2025
|
|
||
| try { | ||
| const logsDir = path.join(process.cwd(), 'logs'); | ||
| const mainPath = process.cwd()?.split("migration-v2")?.[0]; |
Contributor
There was a problem hiding this comment.
const mainPath = process?.cwd?.()?.split?.("migration-v2")?.[0];
| }) | ||
| .filter((entry) => entry !== null); | ||
| return logEntries; | ||
| ?.filter((entry) => entry !== null); |
| return { logs: [], total: 0 }; | ||
| } | ||
|
|
||
| logEntries = logEntries?.slice(1, logEntries.length - 2); |
| if (searchText !== "null") { | ||
| logEntries = logEntries?.filter((log) => { | ||
| return ( | ||
| log?.level?.toLowerCase()?.includes(searchText?.toLowerCase() ?? '') || |
Contributor
There was a problem hiding this comment.
lets create genric func for this
| params?.projectId ?? '' | ||
| ); | ||
|
|
||
| if (status === 200) { |
Contributor
There was a problem hiding this comment.
Let’s create constant for 200
| isRowSelect={false} | ||
| columnSelector={false} | ||
| canSearch={true} | ||
| searchPlaceholder={'Search Execution Logs'} |
| customEmptyState={ | ||
| <EmptyState | ||
| forPage="list" | ||
| heading={searchText === '' ? 'No Logs' : 'No matching results found!'} |
| searchText === '' | ||
| ? 'Try Executing the Migration.' | ||
| : 'Try changing the search query to find what you are looking for.' | ||
| } |
| if (error instanceof Error) { | ||
| throw new Error(`Error in userSession: ${error.message}`); | ||
| } else { | ||
| throw new Error('Unknown error in userSession'); |
sayalijoshi27
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR request to merge Execution Log Screen.