Skip to content

Conversation

@AishDani
Copy link
Contributor

@AishDani AishDani commented Jun 3, 2025

No description provided.

@AishDani AishDani requested a review from a team as a code owner June 3, 2025 09:30
@umeshmore45 umeshmore45 requested a review from Copilot June 3, 2025 10:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the log display components by removing the index element from log entries and makes related style and key improvements consistent with the new design. Additionally, minor documentation and asynchronous behavior adjustments have been made in utility functions and interfaces.

  • Removed the index display and associated CSS class from LogScreen and MigrationLogViewer.
  • Updated the key assignment in AuditFilterModal for improved list rendering.
  • Adjusted SCSS padding and border properties and refined async handling in content-type-creator.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
ui/src/components/LogScreen/index.tsx Removed the log number element and updated className for log entries.
ui/src/components/LogScreen/MigrationLogViewer.tsx Similar removal of the log number element and className adjustments.
ui/src/components/Common/Settings/Settings.scss Updated padding and border-top styling for better visual consistency.
ui/src/components/AuditFilterModal/index.tsx Changed key assignment in map iteration to use a uid for uniqueness.
ui/src/components/AdvancePropertise/advanceProperties.interface.ts Added documentation for the new parameter in updateFieldSettings.
api/src/utils/content-type-creator.utils.ts Fixed variable naming and removed an unnecessary await call in mergeArrays.
Comments suppressed due to low confidence (4)

ui/src/components/LogScreen/index.tsx:281

  • The removal of the log number element is consistent with the refactor, but please confirm that omitting the index in the log entry does not affect log traceability or debugging.
<div className="log-number">{index}</div>

ui/src/components/LogScreen/MigrationLogViewer.tsx:287

  • The index removal in the MigrationLogViewer refactor is in line with the overall design changes; please verify that this does not compromise any expected logging functionality.
<div className="log-number">{index}</div>

ui/src/components/AuditFilterModal/index.tsx:81

  • Ensure that the value used as uid is guaranteed to be unique across filterOptions to avoid potential key duplication issues during list rendering.
const uid = item?.value

api/src/utils/content-type-creator.utils.ts:690

  • Since mergeArrays is a synchronous function, the removal of the await call is appropriate; please double-check that this change aligns with the function's usage elsewhere in the codebase.
const schema =  mergeArrays(matchingGroup?.schema ?? [],field2?.schema ?? [] );

@AishDani AishDani requested a review from sayalijoshi27 June 3, 2025 10:07
@sayalijoshi27 sayalijoshi27 merged commit f1754ac into dev Jun 3, 2025
7 checks passed
umeshmore45 pushed a commit that referenced this pull request Jun 10, 2025
refactor:removed index from logscreen and copilot suggestions
umeshmore45 pushed a commit that referenced this pull request Jun 11, 2025
refactor:removed index from logscreen and copilot suggestions
umeshmore45 pushed a commit that referenced this pull request Jun 11, 2025
refactor:removed index from logscreen and copilot suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants