-
Notifications
You must be signed in to change notification settings - Fork 8
Bug Fixes Execution Log #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yashin4112
commented
Jun 6, 2025
- Added "View Log" option in the action menu.
- Resolved UI issue in the Overlay Cell.
- Fixed table height issue.
- Removed test errors from runcli service.
- Fixed ANSI error in runcli service.
- Added text button in log screen to navigate to the Execution Log screen.
- Left Sidebar onClick issue resolved.
|
@yashin4112 please take look of this copilot suggestions |
…te chnage for back button, unnecessary null checks removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses several UI fixes, bug resolutions, and feature enhancements specifically related to log viewing, filtering, and settings management. Key changes include:
- Adding a "View Log" option with new constants and navigation logic in the log screens.
- Refactoring filter modal interfaces and improving state management in the ExecutionLogs and Settings components.
- Removing test log writing code and updating ANSI code stripping in the runCli service.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/src/utilities/constants.ts | Added new VIEW_LOG constant for the log view option. |
| ui/src/context/app/app.interface.ts | Introduced ISetting and integrated settings into INewMigration with defaults. |
| ui/src/components/LogScreen/index.tsx & MigrationLogViewer.tsx | Implemented navigation logic for viewing logs after migration completion. |
| ui/src/components/FilterModal/* | Updated interface and component names for filter options state management. |
| ui/src/components/ExecutionLogs/index.tsx & index.scss | Enhanced filtering state and log view action; adjusted table and empty state configurations. |
| ui/src/components/Common/Settings/* | Refactored settings state usage from a local active variable to a centralized active_state from newMigrationData. |
| ui/src/components/Common/Modal/LogModal/* | Added new modal component for log details. |
| api/src/services/runCli.service.ts | Removed test log writing block; updated ANSI code stripping regex. |
| api/src/services/migration.service.ts | Added defensive checks when reading log files. |
| ui/src/components/Common/Settings/Settings.scss | Updated styling with minor corrections. |