Skip to content

Conversation

@yashin4112
Copy link
Contributor

  1. Added "View Log" option in the action menu.
  2. Resolved UI issue in the Overlay Cell.
  3. Fixed table height issue.
  4. Removed test errors from runcli service.
  5. Fixed ANSI error in runcli service.
  6. Added text button in log screen to navigate to the Execution Log screen.
  7. Left Sidebar onClick issue resolved.

@yashin4112 yashin4112 requested a review from a team as a code owner June 6, 2025 11:39
@umeshmore45 umeshmore45 requested a review from Copilot June 6, 2025 11:41

This comment was marked as outdated.

@umeshmore45
Copy link
Contributor

@yashin4112 please take look of this copilot suggestions

…te chnage for back button, unnecessary null checks removed
@umeshmore45 umeshmore45 requested a review from Copilot June 8, 2025 14:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses several UI fixes, bug resolutions, and feature enhancements specifically related to log viewing, filtering, and settings management. Key changes include:

  • Adding a "View Log" option with new constants and navigation logic in the log screens.
  • Refactoring filter modal interfaces and improving state management in the ExecutionLogs and Settings components.
  • Removing test log writing code and updating ANSI code stripping in the runCli service.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ui/src/utilities/constants.ts Added new VIEW_LOG constant for the log view option.
ui/src/context/app/app.interface.ts Introduced ISetting and integrated settings into INewMigration with defaults.
ui/src/components/LogScreen/index.tsx & MigrationLogViewer.tsx Implemented navigation logic for viewing logs after migration completion.
ui/src/components/FilterModal/* Updated interface and component names for filter options state management.
ui/src/components/ExecutionLogs/index.tsx & index.scss Enhanced filtering state and log view action; adjusted table and empty state configurations.
ui/src/components/Common/Settings/* Refactored settings state usage from a local active variable to a centralized active_state from newMigrationData.
ui/src/components/Common/Modal/LogModal/* Added new modal component for log details.
api/src/services/runCli.service.ts Removed test log writing block; updated ANSI code stripping regex.
api/src/services/migration.service.ts Added defensive checks when reading log files.
ui/src/components/Common/Settings/Settings.scss Updated styling with minor corrections.

@sayalijoshi27 sayalijoshi27 merged commit 68f8c95 into dev Jun 10, 2025
7 checks passed
@sayalijoshi27 sayalijoshi27 deleted the bugfix/execution-log branch June 10, 2025 09:25
@yashin4112 yashin4112 restored the bugfix/execution-log branch June 11, 2025 06:58
@umeshmore45 umeshmore45 deleted the bugfix/execution-log branch June 11, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants