-
Notifications
You must be signed in to change notification settings - Fork 8
Bugfix/beta release #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/beta release #753
Conversation
… to version 12.9.1
…ndencies in package-lock.json files of upload microservices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses multiple bug fixes across the migration tool, including package version downgrades, UI filtering improvements, and proper handling of undefined values in language mapping and content filtering.
- Package versions downgraded to stable releases (1.0.3) and react-scripts to 0.0.0
- Fixed undefined label handling in language mapping components
- Added proper reference field validation and improved filtering logic
- Enhanced global field service integration for migration processes
Reviewed Changes
Copilot reviewed 13 out of 20 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| upload-api/package.json | Downgraded dependencies to stable versions |
| ui/package.json | Set react-scripts to version 0.0.0 |
| package.json | Downgraded @contentstack/cli-utilities to 1.0.3 |
| ui/src/pages/Migration/index.tsx | Added undefined label filtering in migration logic |
| ui/src/components/DestinationStack/DestinationStack.scss | Added delete-icon styling with padding |
| ui/src/components/DestinationStack/Actions/LoadLanguageMapper.tsx | Enhanced undefined handling and mapping logic |
| ui/src/components/ContentMapper/index.tsx | Fixed filter logic and reference field validation |
| ui/src/components/AdvancePropertise/index.tsx | Fixed reference items mapping and option handling |
| api/src/utils/field-attacher.utils.ts | Added contentTypeId parameter to field lookup |
| api/src/services/migration.service.ts | Integrated global field service calls |
| api/src/services/globalField.service.ts | New service for handling global field operations |
| api/src/services/contentful.service.ts | Commented out global fields file creation |
| .talismanrc | Updated checksums for package-lock.json files |
Files not reviewed (4)
- upload-api/migration-contentful/package-lock.json: Language not supported
- upload-api/migration-sitecore/package-lock.json: Language not supported
- upload-api/migration-wordpress/package-lock.json: Language not supported
- upload-api/package-lock.json: Language not supported
ui/src/components/DestinationStack/Actions/LoadLanguageMapper.tsx
Outdated
Show resolved
Hide resolved
ui/src/components/DestinationStack/Actions/LoadLanguageMapper.tsx
Outdated
Show resolved
Hide resolved
ui/src/components/DestinationStack/Actions/LoadLanguageMapper.tsx
Outdated
Show resolved
Hide resolved
| }, | ||
| "dependencies": { | ||
| "@contentstack/cli-utilities": "^1.8.4" | ||
| "@contentstack/cli-utilities": "^1.0.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we are downgrading the version ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got the snyk security warnings
No description provided.