Skip to content

fix: update ENTRYPOINT path and handle permission errors in entrypoin… #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umeshmore45 merged 1 commit into from
Aug 18, 2025
Merged

fix: update ENTRYPOINT path and handle permission errors in entrypoin… #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion upload-api/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ USER nodeapp

EXPOSE 4002

ENTRYPOINT ["docker-entrypoint.sh"]
ENTRYPOINT ["/usr/local/bin/docker-entrypoint.sh"]

CMD ["npm", "run", "start"]
2 changes: 1 addition & 1 deletion upload-api/docker-entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
set -e

# Fix permissions for extracted_files volume at runtime
chown -R nodeapp:nodeapp /app/extracted_files
chown -R nodeapp:nodeapp /app/extracted_files || true
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using || true to suppress all errors from the chown command could hide legitimate security issues. Consider checking if the directory exists first or only suppressing specific expected errors (e.g., chown -R nodeapp:nodeapp /app/extracted_files 2>/dev/null || [ -d /app/extracted_files ]).

Suggested change
chown -R nodeapp:nodeapp /app/extracted_files || true
[ -d /app/extracted_files ] && chown -R nodeapp:nodeapp /app/extracted_files

Copilot uses AI. Check for mistakes.

exec "$@"