-
Notifications
You must be signed in to change notification settings - Fork 8
Bugfix/beta release #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/beta release #776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements bug fixes related to authentication token management and API service improvements. The changes focus on ensuring proper token handling during login/logout flows and fixing dynamic token retrieval in API calls.
- Added a new
clearAuthTokenaction to properly clear authentication state - Converted static options objects to dynamic functions for fresh token retrieval
- Fixed locale mapping logic to handle key updates correctly
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/store/slice/authSlice.tsx | Added clearAuthToken reducer action and exported it |
| ui/src/services/api/stacks.service.ts | Converted options from static object to function for dynamic token retrieval |
| ui/src/services/api/migration.service.ts | Converted options from static object to function and updated all API calls |
| ui/src/pages/Migration/index.tsx | Added numeric label filtering in locale validation |
| ui/src/pages/Login/index.tsx | Added token clearing logic and imported necessary functions |
| ui/src/components/DestinationStack/Actions/LoadLanguageMapper.tsx | Fixed locale key mapping by adding old key deletion logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@sayalijoshi27 please review this |
No description provided.