fix/CMG-737 refactor: enhance JSON handling in processFieldsRecursive function of… #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… aem.service.ts to support string and object types for content
…elds to AssetJSON interface, implementing helper functions for HTML sanitization and field value extraction, and improving asset deduplication logic Resolved Bugs - CMG-743 CMG-747 CMG-748 CMG-758
sayalijoshi27
requested changes
Oct 28, 2025
Contributor
sayalijoshi27
left a comment
sayalijoshi27
left a comment
There was a problem hiding this comment.
Add null checks in both the files and resolve security scan failed test
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances JSON handling in the AEM service to support both string and object content types, and introduces UID normalization across field mappings to ensure consistent UID formatting throughout the migration process.
Key changes:
- Added
normalizeFieldUidsfunction with recursive UID correction for field mappings, blocks, and schema items - Refactored asset deduplication logic to use filename-based tracking instead of creating duplicates
- Enhanced field processing to support flexible content types (string/object) in JSON RTE fields
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| upload-api/migration-aem/helper/fieldMappings.merge.ts | Introduces UID normalization functions and integrates them into content model processing pipeline |
| api/src/services/aem.service.ts | Refactors asset creation to deduplicate by filename, adds helper functions for field value extraction and HTML sanitization, and enhances field type handling with support for flexible content types |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ge.ts by adding optional chaining to prevent runtime errors
sayalijoshi27
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… aem.service.ts to support string and object types for content