-
Notifications
You must be signed in to change notification settings - Fork 8
Feature/aem final #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/aem final #824
Conversation
…de-server into feature/aem-final
…de-server into feature/aem-final
…de-server into feature/aem-final
…hould be prevented.
…hould be prevented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request focuses on cleaning up code, improving type safety, and standardizing notification UI behavior across the application. The changes include terminology updates from "master" to "default" locale, removing unused imports and code, and enhancing user experience with consistent notification settings.
- Improved type safety by replacing
anytypes with specific types - Standardized notification behavior by setting
hideProgressBar: trueacross all notifications - Updated terminology from "Master Locale" to "Default Locale" throughout the application
- Removed unused imports, commented code, and variables to improve code cleanliness
- Added debouncing and duplicate-click prevention for critical operations
- Fixed button event handlers by moving
onClickfrom Icon to Button component
Reviewed Changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/pages/Migration/index.tsx | Updated LocalesType from any to string type; changed hideProgressBar to true |
| ui/src/pages/Login/index.tsx | Added hideProgressBar property to notification; removed commented-out useEffect code |
| ui/src/components/Modal/index.tsx | Added hideProgressBar to notifications for project creation success/error |
| ui/src/components/LogScreen/MigrationLogViewer.tsx | Removed unused imports (updateCurrentStepData, ModalObj, MigrationCompletionModal) |
| ui/src/components/LegacyCms/index.tsx | Removed unused defaultCardType import |
| ui/src/components/LegacyCms/Actions/LoadUploadFile.tsx | Removed unused CircularLoader import |
| ui/src/components/DestinationStack/Actions/LoadStacks.tsx | Updated "Master Locale" terminology to "Default Locale" |
| ui/src/components/DestinationStack/Actions/LoadLanguageMapper.tsx | Removed unused variables (key, uid, csLocaleKey, stackValue); updated master locale terminology |
| ui/src/components/ContentMapper/index.tsx | Added debounce utility, duplicate-click prevention with isResetFetch state, moved onClick handlers from Icon to Button, relocated handleCTDeleted function, added autoClose property to notification |
| ui/src/components/ContentMapper/index.scss | Adjusted advanced-setting-button padding |
| ui/src/components/Common/AddStack/addStack.tsx | Improved type safety by adding proper types to validation function; updated "master" to "default" language terminology |
| ui/src/components/AdvancePropertise/index.tsx | Removed empty lines; added null-coalescing for options prop; added disabled prop for certain field types |
| .gitignore | Added app.json and Snyk security extension rules to gitignore |
Comments suppressed due to low confidence (1)
ui/src/components/ContentMapper/index.tsx:2093
- Avoid automated semicolon insertion (97% of all statements in the enclosing function have an explicit semicolon).
)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.