-
Notifications
You must be signed in to change notification settings - Fork 8
Pre-Stage pr #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-Stage pr #847
Conversation
…de-server into feature/aem-final
…etion logic and removed checks for affix
…de-server into feature/aem-final
Feature/aem final
…etion logic and removed checks for affix
…tion-v2 into feature/affix
…etion logic and removed checks for affix
…mapping retrieval
Feature/affix
Bugfix/cmg 752
code added to set content type default value for link datatype
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements changes to make the "affix" field optional with a default value of "cs" across the migration workflow. The changes remove affix validation requirements and update related UI components and backend services.
Key changes:
- Made the affix parameter optional with a default value of "cs" in file validation and UI components
- Refactored the
uidCorrectorfunction to improve UID sanitization logic - Updated step completion logic to remove affix-related validation checks
- Enhanced UI elements including HTML rendering support for step descriptions
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 17 comments.
Show a summary per file
| File | Description |
|---|---|
| upload-api/migration-sitecore/libs/contenttypes.js | Added backupFieldUid field to group field mapping |
| ui/src/services/api/upload.service.ts | Added default value 'cs' for affix parameter in file validation |
| ui/src/components/Stepper/VerticalStepper/AutoVerticalStepper.tsx | Enabled HTML rendering for step descriptions using dangerouslySetInnerHTML |
| ui/src/components/Stepper/HorizontalStepper/HorizontalStepper.tsx | Commented out notification call for legacy CMS step changes |
| ui/src/components/LegacyCms/index.tsx | Removed affix validation checks from step completion logic |
| ui/src/components/LegacyCms/Actions/LoadUploadFile.tsx | Removed affix-related validation checks and button disable conditions |
| ui/src/components/LegacyCms/Actions/LoadPrefix.tsx | Added default 'cs' value for prefix and implemented onBlur handler for auto-filling empty values |
| ui/src/components/ContentMapper/index.tsx | Refactored loading state management and commented out custom empty state configuration |
| ui/src/components/ContentMapper/index.scss | Added minimum height to table and commented out rowgroup styles |
| ui/src/cmsData/legacyCms.json | Updated affix description with detailed explanation of default behavior |
| api/src/utils/content-type-creator.utils.ts | Refactored uidCorrector with improved sanitization logic and type safety |
| api/src/services/sitecore.service.ts | Refactored uidCorrector with improved sanitization logic and removed dependency on append variable |
| api/src/services/contentMapper.service.ts | Enhanced query filters to include contentTypeId for more precise data filtering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ui/src/components/Stepper/HorizontalStepper/HorizontalStepper.tsx
Outdated
Show resolved
Hide resolved
copilot comments resolved
No description provided.