fix: Update buildSchemaTree to handle old parent UID and improve fiel… #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AishDani
requested review from
sayalijoshi27 and
umeshmore45
and removed request for
a team
… duplicate fields and improve UID checks
sayalijoshi27
requested changes
Dec 10, 2025
| } | ||
|
|
||
| export function buildSchemaTree(fields: any[], parentUid = '', parentType = ''): any[] { | ||
| export function buildSchemaTree(fields: any[], parentUid = '', parentType = '', oldPrentUid = ''): any[] { |
Contributor
There was a problem hiding this comment.
oldPrentUid correct the spelling
| } | ||
|
|
||
| // Fallback: check if field is a direct child of oldPrentUid (if provided and different) | ||
| if (oldPrentUid && oldPrentUid !== parentUid && fieldUid.startsWith(oldPrentUid + '.')) { |
Contributor
There was a problem hiding this comment.
correct the spelling
| const remainder = fieldUid.substring(oldPrentUid.length + 1); | ||
| // Verify it's exactly one level deeper (no more dots in remainder) | ||
| return remainder && !remainder.includes('.'); | ||
| } |
Contributor
There was a problem hiding this comment.
Add null checks in above function
| if (oldFieldtUid && fUid.startsWith(oldFieldtUid + '.')) { | ||
| const remainder = fUid.substring(oldFieldtUid.length + 1); | ||
| return remainder && !remainder.includes('.'); | ||
| } |
Contributor
There was a problem hiding this comment.
Add null checks in above block
| uid: childUid, | ||
| display_name: childDisplay, | ||
| schema: buildSchemaTree(fields, child.contentstackFieldUid, 'modular_blocks_child') | ||
| schema: buildSchemaTree(fields, child.contentstackFieldUid, 'modular_blocks_child', child?.backupFieldUid) |
Contributor
There was a problem hiding this comment.
child?.contentstackFieldUid
Contributor
Author
There was a problem hiding this comment.
I want the backFieldUId to get the nested child of it if it is mapped to another field
| (fieldType === 'modular_blocks_child' && hasChildren)) { | ||
| // Recursively build schema for groups and modular block children with nested content | ||
| result.schema = buildSchemaTree(fields, fieldUid, fieldType); | ||
| result.schema = buildSchemaTree(fields, fieldUid, fieldType, oldFieldtUid); |
Contributor
There was a problem hiding this comment.
It should be oldFieldUid
…dle optional chaining for field properties
…ng for field UIDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d UID checks