-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix: show md rules and prompts in respective sections #8178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="core/config/markdown/loadMarkdownRules.ts">
<violation number="1" location="core/config/markdown/loadMarkdownRules.ts:57">
This comment still claims we load from multiple directories even though we now only scan .continue/rules. Please update the wording to reflect the single directory.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uinstinct the invokable
property means prompts and rules are the same underlying markdown and rules that are not invokable
in the prompts directory will be stranded. I believe this is the original reason they were both read. You should be able to categorize based on invokable
rather than changing the directory reading.
@tomasz I remember you had done some thinking on this, does that sound right?
@uinstinct @RomneyDa I think this PR is only partially correct. Picking up rules from the prompts folder (and vice versa) is expected and was added in this PR: #8073 I looked at the Linear ticket and the requirement is |
also read .md files from prompt folders
Description
Previously the markdown prompts were showing under the rules sections. This was happening because rules extractor was picking up prompts from the prompts folder also. This PR fixes it.
resolves CON-4160
AI Code Review
@continue-review
Checklist
Screen recording or screenshot
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Fixes misclassification so markdown prompts and rules appear in the correct sections. Rules load only from .continue/rules; prompts load from prompts folders (including .md). Resolves CON-4160.