-
Notifications
You must be signed in to change notification settings - Fork 3.6k
feat: allow file reads outside IDE workspace (w/ permission) #8298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4903f3a
add tool call policy evaluation
Patrick-Erichsen ad2fd48
Merge main branch and resolve conflicts
Patrick-Erichsen bf9a19a
fix: pass preprocessed args to core
Patrick-Erichsen ecbb4e2
dallin's feedback
Patrick-Erichsen 71f97db
prettier
Patrick-Erichsen acad86f
Apply suggestion from @cubic-dev-ai[bot]
Patrick-Erichsen 9388bd2
update subdirectory logic
Patrick-Erichsen b687ce2
Update pathResolver.test.ts
Patrick-Erichsen 0670852
Update viewSubdirectory.vitest.ts
Patrick-Erichsen ee439fa
fix tests
Patrick-Erichsen c38a5bb
use libs for path resolution
Patrick-Erichsen a9f7015
remove unneeded normalize-path
Patrick-Erichsen 211ea1f
add `processedArgs` param
Patrick-Erichsen 0546451
Update createNewFile.ts
Patrick-Erichsen e1d0862
Update streamResponse_toolCalls.test.ts
Patrick-Erichsen 9988674
Update streamResponse_toolCalls.test.ts
Patrick-Erichsen 93d6f7a
eslint errors
Patrick-Erichsen f20dc3f
Update package-lock.json
Patrick-Erichsen 32d8f51
Update DocsCrawler.test.ts
Patrick-Erichsen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
import { ToolPolicy } from "@continuedev/terminal-security"; | ||
|
||
/** | ||
* Evaluates file access policy based on whether the file is within workspace boundaries | ||
* | ||
* @param basePolicy - The base policy from tool definition or user settings | ||
* @param isWithinWorkspace - Whether the file/directory is within workspace | ||
* @returns The evaluated policy - more restrictive for files outside workspace | ||
*/ | ||
export function evaluateFileAccessPolicy( | ||
basePolicy: ToolPolicy, | ||
isWithinWorkspace: boolean | ||
): ToolPolicy { | ||
// If tool is disabled, keep it disabled | ||
if (basePolicy === "disabled") { | ||
return "disabled"; | ||
} | ||
|
||
// Files within workspace use the base policy (typically "allowedWithoutPermission") | ||
if (isWithinWorkspace) { | ||
return basePolicy; | ||
} | ||
|
||
// Files outside workspace always require permission for security | ||
return "allowedWithPermission"; | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.