Skip to content

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Oct 17, 2025

Description

Sonnet 3.5 and Haiku 3.5 do not support thinking and hence should not auto enable the thinking tag. This PR fixes that.

resolves CON-4428

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before

image

after

image

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

@uinstinct uinstinct requested a review from a team as a code owner October 17, 2025 02:56
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team October 17, 2025 02:56
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 17, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add claude 3 to exclusion.
It might make more sense to change it to if model.includes("claude") && ... instead of checking underlying provider name, since the same issue will happen for other providers like bedrock etc

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 17, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@uinstinct
Copy link
Contributor Author

Let's add claude 3 to exclusion.

makes sense. it can be turned on through the config

It might make more sense to change it to if model.includes("claude") && ... instead of checking underlying provider name, since the same issue will happen for other providers like bedrock etc

implemented

@uinstinct uinstinct requested a review from RomneyDa October 17, 2025 11:43
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct claude 4 models can contain "3" in their model string because they can include a date like claude-sonnet-4-11032025

@uinstinct uinstinct requested a review from RomneyDa October 20, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants