-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix: prevent anthropic 3.5 models from use thinking #8303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add claude 3 to exclusion.
It might make more sense to change it to if model.includes("claude") && ...
instead of checking underlying provider name, since the same issue will happen for other providers like bedrock etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
makes sense. it can be turned on through the config
implemented |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uinstinct claude 4 models can contain "3" in their model string because they can include a date like claude-sonnet-4-11032025
Description
Sonnet 3.5 and Haiku 3.5 do not support thinking and hence should not auto enable the thinking tag. This PR fixes that.
resolves CON-4428
AI Code Review
@continue-review
Checklist
Screen recording or screenshot
before
after
Tests
[ What tests were added or updated to ensure the changes work as expected? ]