Skip to content

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Oct 17, 2025

Description

Prevent thinking messages without signatures to be sent to the LLM.

resolves CON-4363

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before.mp4
after.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Prevent sending “thinking” messages without a signature to the LLM to avoid incomplete thoughts being processed. Only include messages with a signature or redactedThinking (addresses Linear CON-4363).

@uinstinct uinstinct requested a review from a team as a code owner October 17, 2025 05:30
@uinstinct uinstinct requested review from RomneyDa and removed request for a team October 17, 2025 05:30
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Oct 17, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only anthropic API has this limitation

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 17, 2025
@uinstinct
Copy link
Contributor Author

I think only anthropic API has this limitation

I see. Do we want to include the thinking portion when it is incomplete?

@RomneyDa
Copy link
Collaborator

I think if you include the thinking portion without a signature it errors, so we can fully ignore thinking messages that don't have signatures at the anthropic llm class/openai adapter level

@RomneyDa
Copy link
Collaborator

@uinstinct I did this as a hotfix for haiku 4.5 here
#8329

@RomneyDa RomneyDa closed this Oct 18, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Oct 18, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2025
@uinstinct uinstinct deleted the incomplete-thinking branch October 20, 2025 05:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants