Skip to content

Conversation

uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Oct 17, 2025

Description

Automatically accept all edit file tools (edit existing file, single find and replace, multi-edit) because accept/reject file diffs will be shown for them anyway.

resolves CON-4427

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Automatically auto-approve file edit tools and remove them from policy controls. Users still see diffs to accept or reject. Resolves CON-4427.

  • New Features
    • Edit tools (edit file, single find/replace, multi-edit) are always allowed without permission; diffs remain for approval.
    • Removed the autoAcceptEditToolDiffs setting dependency.
    • Hidden edit tools from the Tool Policies UI to avoid misleading controls.

@uinstinct uinstinct requested a review from a team as a code owner October 17, 2025 12:24
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team October 17, 2025 12:24
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 17, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct looks like just pending tests! GUI edit tests account for policies

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct instead of hiding edit tools from policies, can we just get rid of the auto-accept agent edits setting entirely?

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Oct 20, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 20, 2025
@uinstinct uinstinct changed the title feat: automatically accept file edit tools feat: remove auto-accept edits setting Oct 20, 2025
@uinstinct uinstinct requested a review from RomneyDa October 20, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants