-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat: submit slash command in one enter #8928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Keep this PR in a mergeable state → Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
Document that slash commands now submit on Enter (except /title) rather than requiring Tab first. Generated with [Continue](https://continue.dev) Co-Authored-By: Continue <[email protected]> Co-authored-by: nate <[email protected]>
|
Updated documentation in
This keeps the docs aligned with the new UX improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 1 file
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="extensions/cli/src/ui/UserInput.tsx">
<violation number="1" location="extensions/cli/src/ui/UserInput.tsx:471">
Quick-submitted slash commands bypass the queue/backpressure logic and call onSubmit even while a response is already in progress, so commands can now be sent concurrently in situations the rest of the input flow explicitly queues.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="extensions/cli/src/ui/UserInput.tsx">
<violation number="1" location="extensions/cli/src/ui/UserInput.tsx:471">
Submitting a slash command now bypasses the queue used while a response/compaction is in progress, so Enter on a slash command can ignore `isWaitingForResponse` and interleave messages instead of enqueueing them.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uinstinct I think the cubic feedback is valid, is it possible to queue it up instead of submit immediately? I didn't fully test but there might be a simple way to use the queuing method rather than the onsubmit
I wanted your thoughts on this one - enqueuing is the more bulletproof option and upon testing, submitting command directly works fine (even if we change to suitable models) with most of the slash commands. have add support for enqueuing in the last commit |
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Enter submits the highlighted slash command directly (except /title, which requires Tab to select first).
- Tab selects the highlighted command without submitting.
@uinstinct I think the descriptions here don't match behavior, since Enter will select title as well it just won't submit it (if that's not the behavior it should be)
It should prompt the user to the title of the chat if not provided. Something like this: demo.mp4 |
Description
Previously it requires 2 enter keys to submit slash commands. This PR helps it to be done in one enter key.
resolves CON-4937
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
before.mp4
after.mp4
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Submit slash commands in the CLI with one Enter press, removing the previous two-step flow. Implements Linear CON-4937.
Written for commit 4cf3374. Summary will update automatically on new commits.