Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Nov 28, 2025

Description

Previously it requires 2 enter keys to submit slash commands. This PR helps it to be done in one enter key.

resolves CON-4937

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

before.mp4
after.mp4

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Submit slash commands in the CLI with one Enter press, removing the previous two-step flow. Implements Linear CON-4937.

  • New Features
    • Enter submits the highlighted command; Tab selects without submitting. /title stays select-only and Enter selects it.
    • Adds the command to history; enqueues if a response is generating, otherwise submits; then clears the input and resets UI state.

Written for commit 4cf3374. Summary will update automatically on new commits.

@uinstinct uinstinct requested a review from a team as a code owner November 28, 2025 14:16
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team November 28, 2025 14:16
@continue
Copy link
Contributor

continue bot commented Nov 28, 2025

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 28, 2025
Document that slash commands now submit on Enter (except /title) rather than requiring Tab first.

Generated with [Continue](https://continue.dev)

Co-Authored-By: Continue <[email protected]>
Co-authored-by: nate <[email protected]>
@continue
Copy link
Contributor

continue bot commented Nov 28, 2025

Updated documentation in extensions/cli/spec/shell-mode.md to document the new single-enter submission behavior for slash commands. The spec now clarifies that:

  • Enter submits the highlighted slash command directly (except /title)
  • Tab selects the highlighted command without submitting

This keeps the docs aligned with the new UX improvement.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (all 1 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="extensions/cli/src/ui/UserInput.tsx">

<violation number="1" location="extensions/cli/src/ui/UserInput.tsx:471">
Quick-submitted slash commands bypass the queue/backpressure logic and call onSubmit even while a response is already in progress, so commands can now be sent concurrently in situations the rest of the input flow explicitly queues.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all 1 issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="extensions/cli/src/ui/UserInput.tsx">

<violation number="1" location="extensions/cli/src/ui/UserInput.tsx:471">
Submitting a slash command now bypasses the queue used while a response/compaction is in progress, so Enter on a slash command can ignore `isWaitingForResponse` and interleave messages instead of enqueueing them.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct I think the cubic feedback is valid, is it possible to queue it up instead of submit immediately? I didn't fully test but there might be a simple way to use the queuing method rather than the onsubmit

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Dec 3, 2025
@uinstinct
Copy link
Contributor Author

@uinstinct I think the cubic feedback is valid, is it possible to queue it up instead of submit immediately? I didn't fully test but there might be a simple way to use the queuing method rather than the onsubmit

I wanted your thoughts on this one - enqueuing is the more bulletproof option and upon testing, submitting command directly works fine (even if we change to suitable models) with most of the slash commands.

have add support for enqueuing in the last commit

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Enter submits the highlighted slash command directly (except /title, which requires Tab to select first).
  • Tab selects the highlighted command without submitting.

@uinstinct I think the descriptions here don't match behavior, since Enter will select title as well it just won't submit it (if that's not the behavior it should be)

@uinstinct
Copy link
Contributor Author

  • Enter submits the highlighted slash command directly (except /title, which requires Tab to select first).
  • Tab selects the highlighted command without submitting.

@uinstinct I think the descriptions here don't match behavior, since Enter will select title as well it just won't submit it (if that's not the behavior it should be)

It should prompt the user to the title of the chat if not provided. Something like this:

demo.mp4

@uinstinct uinstinct requested a review from RomneyDa December 5, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants