fix: lsTool path management and improve workspace file resolution #8985

andreapizzato · 2025-12-03T10:06:43Z

Description

Code changes:

removed custom path rewriter for lsTool using the IDE/Platform-provided path resolution
fixed an issue where a file could be resolved within the workspace but being reported as non-existent

Targeted issues

Here's a few of the issues I've found which should be cleared with this change:

AI Code Review

Team members only: AI review runs automatically when PR is opened or marked ready for review
Team members can also trigger a review by commenting @continue-review

Checklist

I've read the contributing guide
The relevant docs, if any, have been updated or created
The relevant tests, if any, have been updated or created

Screen recording or screenshot

The best demo of this fix is to compare the current main with the branch running the same task; you can view the demo I just recorded.

Tests

I actually had to remove some tests because they were testing the removed function; that specific functionality is tested elsewhere both in the codebase and in the supporting vscode/node SDKs.

Summary by cubic

Switch lsTool to the IDE path resolver and fix workspace URI checks to prevent false “directory/file not found” errors. Addresses #8877, #8744, #6220.

Bug Fixes
- Use IDE-provided path resolution in lsTool; remove custom path rewriter.
- Verify file existence using the resolved workspace URI, not the raw input.
- Return a clear error when dirPath is missing.

^{Written for commit 9a7d15b. Summary will update automatically on new commits.}

…h resolver

… of the unresolved one

continue · 2025-12-03T10:06:47Z

Keep this PR in a mergeable state →

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

github-actions · 2025-12-03T10:06:57Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

andreapizzato · 2025-12-03T10:08:18Z

I have read the CLA Document and I hereby sign the CLA

continue · 2025-12-03T10:09:39Z

Documentation Review

I've reviewed this PR for documentation updates. No documentation changes are needed because:

Internal refactoring only - The changes simplify internal path handling without affecting the user-facing API
No API changes - The ls tool still accepts the same parameters (dirPath and recursive)
No existing documentation describes the internal path resolution logic that was changed
The tool definition in core/tools/definitions/ls.ts remains unchanged

The improvements (removing custom path rewriting, fixing workspace file resolution) are implementation details that don't require user documentation updates.

cubic-dev-ai

No issues found across 3 files

RomneyDa

Some nitpicks, otherwise the core changes lgtm

RomneyDa · 2025-12-03T20:08:30Z

core/util/pathResolver.ts

 async function isUriWithinWorkspace(ide: IDE, uri: string): Promise<boolean> {
  const workspaceDirs = await ide.getWorkspaceDirs();
-  const { foundInDir } = findUriInDirs(uri, workspaceDirs);
+  const { foundInDir, uri: foundUri } = findUriInDirs(uri, workspaceDirs);


This should be unnecessary, foundUri and original uri should be the same

Sorry, my bad, I didn't go deeper looking at the implementation of findUriInDirs: it is, in fact, the same. This change does not make sense, will push a new commit removing it 👍

RomneyDa · 2025-12-03T20:09:11Z

core/tools/implementations/lsTool.vitest.ts

-  expect(resolveLsToolDirPath("")).toBe("/");
-});
-
-test("resolveLsToolDirPath handles dot", () => {


Why remove these tests? Should we only remove the ones checking for empty path?

The input path is now only processed through resolveInputPath (core/tools/implementations/lsTool.ts:18 in this PR); therefore I had to remove the tests because the function itself is no longer existing. This does not mean at all those tests were unnecessary and shouldn't be brought back; in fact I discovered this bug trying to use SpecKit (which hosts scripts inside a .speckit folder) and Continue was madly looping unable to read files that were in fact there. Basically I'd love to bring back the old tests + tests for files and folders starting with a . (e,g, .env, .git).

Is it better to test for those cases while testing resolveInputPath alone or do we want to have a separate function evaluating ls input path to be able to bring back these tests?

In the original path parsing function (resolveLsToolDirPath - core/tools/implementations/lsTool.ts:8 in this PR):

why was '.' (current folder) replaced with '/' filesystem root?

what was the original intent behind removing the initial '.' from a path? Preventing access to parent folders?

Ah, thanks for explaining. The simple reason is that "." doesn't work with our file reading and listing IDE utils, they require URIs, so we assume "." means relative. So you're right that it's a bug. I think the fix is that "." and "./" paths should resolve relative to the workspace URI root (first workspace if there are multiple)

hackmajoris · 2025-12-04T18:07:40Z

waiting for this

RomneyDa

Added a nitpick and bump on previous review comments

RomneyDa · 2025-12-05T17:43:22Z

core/tools/implementations/lsTool.ts

-  const resolvedPath = await resolveInputPath(extras.ide, dirPath);
+  if (!args.dirPath) {
+    throw new ContinueError(
+      ContinueErrorReason.Unspecified,


@andreapizzato please add a ContinueErrorReason for this or use an existing one

andreapizzato added 2 commits December 3, 2025 10:35

fix(lsTool): Remove custom path reinterpreter in favor of the IDE pat…

19f0815

…h resolver

fix(pathResolver): Check the final computed URI for existence instead…

de930a7

… of the unresolved one

andreapizzato requested a review from a team as a code owner December 3, 2025 10:06

andreapizzato requested review from Patrick-Erichsen and removed request for a team December 3, 2025 10:06

github-project-automation bot moved this to Todo in Issues and PRs Dec 3, 2025

github-project-automation bot added this to Issues and PRs Dec 3, 2025

dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Dec 3, 2025

cubic-dev-ai bot reviewed Dec 3, 2025

View reviewed changes

andreapizzato changed the title ~~Fix lsTool path management and improve workspace file resolution~~ fix: lsTool path management and improve workspace file resolution Dec 3, 2025

andreapizzato added 2 commits December 3, 2025 11:59

chore(pathResolver): Enhance comments

931d455

chore(pathResolver): Enhance comments

9a7d15b

RomneyDa requested changes Dec 3, 2025

View reviewed changes

github-project-automation bot moved this from Todo to In Progress in Issues and PRs Dec 3, 2025

RomneyDa requested changes Dec 5, 2025

View reviewed changes

fix: lsTool path management and improve workspace file resolution #8985

Are you sure you want to change the base?

fix: lsTool path management and improve workspace file resolution #8985

Conversation

andreapizzato commented Dec 3, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Targeted issues

AI Code Review

Checklist

Screen recording or screenshot

Tests

Summary by cubic

Uh oh!

continue bot commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andreapizzato commented Dec 3, 2025

Uh oh!

continue bot commented Dec 3, 2025

Documentation Review

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

RomneyDa left a comment

Choose a reason for hiding this comment

Uh oh!

RomneyDa Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

andreapizzato Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

RomneyDa Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

andreapizzato Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

RomneyDa Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

hackmajoris commented Dec 4, 2025

Uh oh!

RomneyDa left a comment

Choose a reason for hiding this comment

Uh oh!

RomneyDa Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

andreapizzato commented Dec 3, 2025 •

edited by cubic-dev-ai bot

Loading

github-actions bot commented Dec 3, 2025 •

edited

Loading