Fixes problem of working on structs with only a single element #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianparpart
force-pushed
the
fix/single-value-structs
branch
from
e26a741 to
6bc8d85
Compare
Yaraslaut
reviewed
Dec 11, 2024
Member
Yaraslaut
left a comment
Yaraslaut
left a comment
There was a problem hiding this comment.
Comment regarding constrains on the types that can be used with the library
christianparpart
force-pushed
the
fix/single-value-structs
branch
2 times, most recently
from
91f2d18 to
19788a1
Compare
Member
Author
|
@Yaraslaut i've been rewriting For Lightweight I don't care too much, because on Fedora (Clang/GCC) it compiles as well as MSVC (VS 2022) compiles perfectly, but I'm afraid we might need some older compilers for Contour. Do you have an idea on how to catch the root cause here, or how to work around it? |
Yaraslaut
force-pushed
the
fix/single-value-structs
branch
from
fb3242c to
9186051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in Lightweight I noticed, that we cannot work on single-value structs. Hence, this fix here (or workaround? Well, at least it's working) :)