Merged
Conversation
f3l1x
force-pushed
the
claude/remove-doctrine-annotations-OcABF
branch
from
960d37b to
b0d304d
Compare
Member
|
@f3l1x I think that this classes can be deleted (or marked as deprecated) because they exists mainly for annotations:
|
f3l1x
force-pushed
the
claude/remove-doctrine-annotations-OcABF
branch
from
b0d304d to
0835f31
Compare
- Remove doctrine/annotations and koriym/attributes dependencies - Create AttributeLoader to replace DoctrineAnnotationLoader - Inline attribute reading directly into AttributeLoader (no separate reader class) - Remove LoaderFactory directory (DualReaderFactory, NativeAttributeReader) - Delete obsolete wrapper classes: Negotiations, RequestParameters, Responses - Remove @annotation, @target, @NamedArgumentConstructor docblock annotations - Replace AnnotationException with InvalidArgumentException - Update SymfonyValidator to use only attribute-based validation - Convert all test fixtures from docblock annotations to PHP 8 attributes - Rename test files to reflect new naming - Require nette/utils ^4.1.0 This is a breaking change - docblock annotations are no longer supported.
f3l1x
force-pushed
the
claude/remove-doctrine-annotations-OcABF
branch
from
0835f31 to
17fb3a9
Compare
Member
Author
Good point, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change - docblock annotations are no longer supported.