Mark broken regression tests as incomplete #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in a2ccdcf (#83) but has not been fixed so far. When a group is created inside the modifier, clicking the create button will cause one more fieldset to be created than there are containers: ```html <form action="/" method="post" id="frm-form"> <fieldset> <legend>Team member #1</legend> <table> <tr> <th><label for="frm-form-members-0-name">Name</label></th> <td><input type="text" name="members[0][name]" id="frm-form-members-0-name" class="text"></td> </tr> </table> </fieldset> <fieldset> <legend>Team member #2</legend> <table> <tr> <th><label for="frm-form-members-1-name">Name</label></th> <td><input type="text" name="members[1][name]" id="frm-form-members-1-name" class="text"></td> </tr> </table> </fieldset> <fieldset> <legend>Team member #3</legend> </fieldset> <table> <tr> <th></th> <td><input type="submit" name="members[multiplier_creator]" class=" button" value="add" formnovalidate data-nette-validation-scope='["members"]'></td> </tr> </table> <input type="hidden" name="_do" value="form-submit"> </form> ``` ``` Test tests/unit/CreateButtonTest.php:testFieldsets After adding a container, there should be two fieldsets. Failed asserting that actual size 3 matches expected size 2. ```
The nested multipliers were fixed in 39725d3 but the change broke other features so it was reverted in 71cc347 (keeping the test change since it was what we want). See #92 for some more details. Another regression test was introduced in 1e6e3b2 to ensure the nested multiplier support is correctly implemented. However, proper implementation has not manifested so far so let’s mark the tests as incomplete until then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced these tests as plan for fixing #56 and #83 but have not found time to fix them yet. Let’s ignore the known bad tests for now.