Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 337d453208
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| julia = "1.10" | ||
|
|
||
| [sources] | ||
| OptimalControlProblems = {url = "https://github.com/control-toolbox/OptimalControlProblems.jl", rev = "206-dev-test-all-new-problems-with-gpu"} No newline at end of file |
There was a problem hiding this comment.
Pin OptimalControlProblems to an immutable revision
Using a branch name in [sources] makes this dependency a moving target, so two runs of the same CTBenchmarks commit can resolve different OptimalControlProblems code once that branch advances. In this repository that directly affects benchmark reproducibility (and can also introduce sudden breakage from upstream API changes), so this source override should be pinned to a commit SHA rather than a mutable branch ref.
Useful? React with 👍 / 👎.
✅ Benchmark and Documentation CompleteThe automated workflow has completed successfully! 🎉 ✅ Completed Tasks
📖 Documentation Preview
📋 Results
🔗 Links🤖 This notification was automatically generated 2026-03-05 08:00:16 (UTC-2) |
Results saved to docs/src/assets/benchmarks/core-ubuntu-latest/core-ubuntu-latest.json Includes environment TOMLs and benchmark script
Results saved to docs/src/assets/benchmarks/core-ubuntu-latest/core-ubuntu-latest.json Includes environment TOMLs and benchmark script
|
@ocots @jbcaillau c'est normal que le run bench mothra gpu ne marche pas ? |
|
@AmielMetier @HediChennoufi oui : il faut utiliser kkt (pas mothra !) |
|
@ocots @jbcaillau kkt est disponible pour qu'on puisse implémenter le run ? |
…ntrol-toolbox/CTBenchmarks.jl into 154-general-test-problems-gpu
Results saved to docs/src/assets/benchmarks/core-ubuntu-latest/core-ubuntu-latest.json Includes environment TOMLs and benchmark script
|
Oui kkt est dispo. Il faut créer un nouveau label je pense. |
|
@ocots pour kkt y a pas de benchmark dans le dossier benchmark, donc on ne peut pas créer le label, on doit créer tous le reste ? |
|
Oui il faut tout créer, script, entrée dans le registre et label. Pour le label c'est indépendant du reste. |
d'accord mais on met quoi dans ça { |
Results saved to docs/src/assets/benchmarks/core-kkt/core-kkt.json Includes environment TOMLs and benchmark script
…ntrol-toolbox/CTBenchmarks.jl into 154-general-test-problems-gpu
Results saved to docs/src/assets/benchmarks/core-kkt/core-kkt.json Includes environment TOMLs and benchmark script
…ntrol-toolbox/CTBenchmarks.jl into 154-general-test-problems-gpu
Results saved to docs/src/assets/benchmarks/core-kkt/core-kkt.json Includes environment TOMLs and benchmark script
Results saved to docs/src/assets/benchmarks/core-ubuntu-latest/core-ubuntu-latest.json Includes environment TOMLs and benchmark script
Results saved to docs/src/assets/benchmarks/core-kkt/core-kkt.json Includes environment TOMLs and benchmark script
Results saved to docs/src/assets/benchmarks/core-kkt/core-kkt.json Includes environment TOMLs and benchmark script
No description provided.