Support PHP 8.5 #335
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||||
| ### Added | ||||||
| - Support PHP 8.5 | ||||||
|
There was a problem hiding this comment. 🛑 Premature Version Claim: Claiming PHP 8.5 support is misleading since PHP 8.5 is not yet released (scheduled for November 2025). This could confuse users about actual compatibility.
Suggested change
|
||||||
|
|
||||||
| ### Removed | ||||||
| - Support PHP 7.3, 7.4, 8.0 | ||||||
| - Support Laravel ~6.0, ~7.0 | ||||||
|
|
||||||
| ## [v2.7.0] | ||||||
| ### Added | ||||||
| - Support for RabbitMQ 4.x.x | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -17,17 +17,17 @@ | |||||
| } | ||||||
| ], | ||||||
| "require": { | ||||||
| "php": ">=8.1", | ||||||
| "ext-json": "*", | ||||||
| "ext-sockets": "*", | ||||||
| "php-amqplib/php-amqplib": "^3.1", | ||||||
| "laravel/framework": "^8.22.1|^9.2|^10.0|^11.0|^12.0" | ||||||
| }, | ||||||
| "require-dev": { | ||||||
| "ext-curl": "*", | ||||||
| "phpunit/phpunit": "^10.0|^11.0", | ||||||
| "squizlabs/php_codesniffer": "^2.5", | ||||||
| "orchestra/testbench": "^6.21|^8.0|^9.0|^10.0", | ||||||
|
There was a problem hiding this comment. 🛑 Compatibility Gap: Missing orchestra/testbench version ^7.0 creates a gap between ^6.21 and ^8.0, potentially causing dependency resolution issues for Laravel 8.x projects.
Suggested change
|
||||||
| "mockery/mockery": "^1.3" | ||||||
| }, | ||||||
| "autoload": { | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -5,10 +5,16 @@ | |||||
| 3. [Configuring Pigeon](#configuring) | ||||||
|
|
||||||
| ## Requirements | ||||||
| - JSON PHP extension | ||||||
| - Sockets PHP Extension | ||||||
|
|
||||||
| ## Compatibility | ||||||
| | Package Version | PHP Compatibility | Laravel Compatibility | | ||||||
| |-----------------|-------------------|------------------------| | ||||||
| | Version 1 | >= 7.1.3 | 5.6, 6.x, 7.x, 8.x | | ||||||
| | Version 2 | >= 7.3 | 6.20.12+, 7.30.4+, 8.22.1+, 9.x, 10.x, 11.x, 12.x | | ||||||
| | Version 3 | >= 8.1 | 8.22.1+, 9.x, 10.x, 11.x, 12.x | | ||||||
|
There was a problem hiding this comment. 🛑 Version Inconsistency: The documentation shows "Version 3" for PHP >= 8.1, but the changelog indicates this is v2.8.0. This creates confusion about the actual version scheme and could mislead users about compatibility.
Suggested change
|
||||||
|
|
||||||
| ## Installing | ||||||
| Pigeon utilizes [Composer](https://getcomposer.org/) to manage its dependencies. So, before using Laravel, make sure you have Composer installed on your machine. | ||||||
|
|
||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛑 Premature Version Support: PHP 8.5 is not yet released and may cause CI failures. PHP 8.5 is scheduled for release in November 2025, but this workflow will fail until then because the version doesn't exist in setup-php action.