Open
Conversation
Updating master with base
…ds AMQPConnectionClosedException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, @jleonardolemos! I’ve opened this pull request to address an issue that occurs when using Pigeon with a queue worker.
The Problem
In
PigeonServiceProvider, the manager is registered as a singleton:Since the queue worker keeps the singleton instance alive for the entire lifetime of the command, the underlying connection may eventually be lost. 😞
Proposed Solution
I reused the
missedHeartBeatmethod to handleAMQPConnectionClosedException, instead of onlyAMQPHeartbeatMissedException, since the latter extends the same closed connection context.Another option would be to catch
RuntimeException, as it covers both exceptions mentioned above. However, I’d prefer to validate this approach incrementally before broadening the scope too much.P.S.: I don’t think we should handle TimeoutException or IOException at this point.
What are your thoughts?