Skip to content

refactor: replace lodash.uniq with simple code #4600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
escapedcat merged 2 commits into from
Jan 23, 2026
+3 −17
Merged

refactor: replace lodash.uniq with simple code #4600

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b55c1b9
chore: replace lodash.uniq with simple code
hyperz111 Jan 22, 2026
93909c2
chore: use better name
hyperz111 Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions @commitlint/load/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
"@commitlint/test": "^20.0.0",
"@types/lodash.isplainobject": "^4.0.8",
"@types/lodash.merge": "^4.6.8",
"@types/lodash.uniq": "^4.5.8",
"@types/node": "^18.19.17",
"conventional-changelog-atom": "^4.0.0",
"typescript": "^5.2.2"
Expand All @@ -53,8 +52,7 @@
"cosmiconfig": "^9.0.0",
"cosmiconfig-typescript-loader": "^6.1.0",
"lodash.isplainobject": "^4.0.6",
"lodash.merge": "^4.6.2",
"lodash.uniq": "^4.5.0"
"lodash.merge": "^4.6.2"
},
"gitHead": "e82f05a737626bb69979d14564f5ff601997f679"
}
4 changes: 2 additions & 2 deletions @commitlint/load/src/load.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import {
} from "@commitlint/types";
import isPlainObject from "lodash.isplainobject";
import merge from "lodash.merge";
import uniq from "lodash.uniq";

import { loadConfig } from "./utils/load-config.js";
import { loadParserOpts } from "./utils/load-parser-opts.js";
Expand Down Expand Up @@ -85,7 +84,8 @@ export default async function load(

let plugins: PluginRecords = {};
if (Array.isArray(extended.plugins)) {
for (const plugin of uniq(extended.plugins)) {
const uniq = [...new Set(extended.plugins)];
for (const plugin of uniq) {
if (typeof plugin === "string") {
plugins = await loadPlugin(
plugins,
Expand Down
12 changes: 0 additions & 12 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1914,13 +1914,6 @@
dependencies:
"@types/lodash" "*"

"@types/lodash.uniq@^4.5.8":
version "4.5.9"
resolved "https://registry.npmjs.org/@types/lodash.uniq/-/lodash.uniq-4.5.9.tgz#9a5390422c003ca6d0219207ed6c9c38e37a783f"
integrity sha512-2Vd5avnDMNLbDSnUwwgwExKXvX9W3CN72rodT+ikGqGHXn7gVK6BM6Z+kHonbpGgCI2BzM+QDMHrkgKoofOi6A==
dependencies:
"@types/lodash" "*"

"@types/lodash.upperfirst@^4.3.8":
version "4.3.9"
resolved "https://registry.npmjs.org/@types/lodash.upperfirst/-/lodash.upperfirst-4.3.9.tgz#66e150885a67866ed8bc4331c8c305ab682a198c"
Expand Down Expand Up @@ -5491,11 +5484,6 @@ lodash.startcase@^4.4.0:
resolved "https://registry.npmjs.org/lodash.startcase/-/lodash.startcase-4.4.0.tgz#9436e34ed26093ed7ffae1936144350915d9add8"
integrity sha512-+WKqsK294HMSc2jEbNgpHpd0JfIBhp7rEV4aqXWqFr6AlXov+SlcgB1Fv01y2kGe3Gc8nMW7VA0SrGuSkRfIEg==

lodash.uniq@^4.5.0:
version "4.5.0"
resolved "https://registry.npmjs.org/lodash.uniq/-/lodash.uniq-4.5.0.tgz#d0225373aeb652adc1bc82e4945339a842754773"
integrity sha512-xfBaXQd9ryd9dlSDvnvI0lvxfLJlYAZzXomUYzLKtUeOQvOP5piqAWuGtrhWeqaXK9hhoM/iyJc5AV+XfsX3HQ==

lodash.upperfirst@^4.3.1:
version "4.3.1"
resolved "https://registry.npmjs.org/lodash.upperfirst/-/lodash.upperfirst-4.3.1.tgz#1365edf431480481ef0d1c68957a5ed99d49f7ce"
Expand Down
Loading