Prerelease script on index#683
Open
almarro1 wants to merge 4 commits intoconventional-changelog:masterfrom
Open
Prerelease script on index#683almarro1 wants to merge 4 commits intoconventional-changelog:masterfrom
almarro1 wants to merge 4 commits intoconventional-changelog:masterfrom
Conversation
added 3 commits
November 13, 2020 18:13
the script is not executed when skip.bump is set to true
…e script is not executed when skip.bump is set to true
…ro1/standard-version into prerelease-script-on-index
eemeli
approved these changes
Nov 15, 2020
Member
|
Hey @almarro1, thank you for your contribution. This change set looks good to me – it seems like we might want this to land in a major since this could result in potentially unexpected behavior for consumers. I'm running through a few clean-up tasks in the package but will make sure this change gets added in the next major. Thanks again! |
Author
|
Perfect @jbottigliero |
jbottigliero
approved these changes
Dec 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #682