Conversation
nclaeys
commented
Feb 3, 2026
nclaeys
commented
- Update the release notes document if needed in the release notes
- When updating the UI please provide screenshots or videos to the reviewers
nclaeys
requested review from
pascal-knapen,
stijn-janssens,
stijndehaes and
vlieven
as code owners
vlieven
left a comment
vlieven
left a comment
There was a problem hiding this comment.
I agree with the conclusion, but I think we should include Kafka as an option. Not in order to pick it, but to justify for posterity why we don't use it.
| - access grants | ||
| - team changes | ||
| to enable external systems to react and provision necessary infrastructure. | ||
| We will implement this as an extension from the existing audit mechanism, by enriching them to business events and sending them to a queue. |
There was a problem hiding this comment.
Should we also have an ADR on how to implement this?
There was a problem hiding this comment.
I do not see what you want to write about this in an adr? For me this is an implementation detail that does not require an adr.
There was a problem hiding this comment.
I think business events is a pretty vague description, so even just an example would help
Added it to the adr. |
| * Operational simplicity and troubleshooting | ||
|
|
||
| ## Considered Options | ||
| * **Option 1: Cloud-native message brokers** (Queueing system like SQS, Azure queues) |
There was a problem hiding this comment.
I think sqs should be replaced by sns no? When people want multiple consumers this is a nicer way to do it, or will we support sending to multiple queues at once?
There was a problem hiding this comment.
I am missing a decision on: Will all events be sent in a single queue, or will different kinds of events be sent to different queues?
When we sent things to a single queue how will we support them differentiating between events? For example on sqs you can add attributes, but that won't work on every system.
Also will we help people with an SDK or something that helps them?
| - access grants | ||
| - team changes | ||
| to enable external systems to react and provision necessary infrastructure. | ||
| We will implement this as an extension from the existing audit mechanism, by enriching them to business events and sending them to a queue. |
There was a problem hiding this comment.
I think business events is a pretty vague description, so even just an example would help
4 participants
