Closed
Conversation
stijn-janssens
requested review from
nclaeys,
pascal-knapen,
stijndehaes and
vlieven
as code owners
nclaeys
reviewed
Feb 11, 2026
| schema: str = "" | ||
| configuration_type: Literal[DataOutputTypes.PostgresTechnicalAssetConfiguration] | ||
| table: str = "*" | ||
| bucket_identifier: str = "" |
Collaborator
There was a problem hiding this comment.
What does the bucket_identifier mean in a postgres configuration? I do not expect this here.
nclaeys
reviewed
Feb 11, 2026
| class PostgresConfig(BaseEnvironmentPlatformServiceConfigurationDetail): | ||
| database_name: str | ||
| bucket_identifier: str | ||
| s3_path: str |
Collaborator
There was a problem hiding this comment.
What does the s3 path mean in the postgresConfig? I do not expect this here.
nclaeys
reviewed
Feb 11, 2026
| configuration_type: Literal[DataOutputTypes.PostgresTechnicalAssetConfiguration] | ||
| table: str = "*" | ||
| bucket_identifier: str = "" | ||
| database_path: str = "" |
Collaborator
There was a problem hiding this comment.
What is the point of table_path and database_path?
nclaeys
reviewed
Feb 11, 2026
| name: ClassVar[str] = "PostgresTechnicalAssetConfiguration" | ||
| version: ClassVar[str] = "1.0" | ||
|
|
||
| database: str |
Collaborator
There was a problem hiding this comment.
When looking at databases, I would expect:
- host
- port
- database
- schema
- table
To distinguish individual tables. Is there a reason why we do not add host and port?
Collaborator
Author
|
Closing in favor of #2809 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2627
Postgresql platform tile currently does not do anything. I don't want to hardcode this and immediately fix the url in the plugin