Enable domain visualization on graph explorer #2810
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
There was a problem hiding this comment. tests should be placed in the tests folder
Contributor
There was a problem hiding this comment. No in front end testing, it is preferred to place it next to the component
Collaborator
There was a problem hiding this comment. :o that feels weird :D But okay! Learned something new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import { Position } from '@xyflow/react'; | ||
| import { describe, expect, it, vi } from 'vitest'; | ||
|
|
||
| import type { Node as GraphNode } from '@/store/api/services/generated/dataProductsApi'; | ||
| import { parseRegularNode, sharedAttributes } from '@/utils/node-parser.helper'; | ||
|
|
||
| // Minimal GraphNode factory — only fields the parser actually reads. | ||
| // `import type` is erased at compile time so it does not trigger module execution. | ||
| const graphNode = (domain_id: string | null = null, domain: string | null = null): GraphNode => ({ | ||
| id: 'node-1', | ||
| type: 'dataProductNode' as GraphNode['type'], | ||
| isMain: false, | ||
| data: { | ||
| id: 'node-1', | ||
| name: 'Test Product', | ||
| icon_key: 'ANALYTICS', | ||
| domain_id, | ||
| domain, | ||
| description: null, | ||
| link_to_id: null, | ||
| }, | ||
| }); | ||
|
|
||
| const noop = vi.fn(); | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
| // parentId assignment (the core change this PR makes) | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| describe('sharedAttributes — domainsEnabled', () => { | ||
| it('sets parentId to domain_id when domainsEnabled=true and domain_id is present', () => { | ||
| const node = sharedAttributes(graphNode('dom-1', 'Finance'), noop, true, false); | ||
| expect(node.parentId).toBe('dom-1'); | ||
| }); | ||
|
|
||
| it('does not set parentId when domainsEnabled=false even if domain_id is present', () => { | ||
| const node = sharedAttributes(graphNode('dom-1', 'Finance'), noop, false, false); | ||
| expect(node.parentId).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('does not set parentId when domain_id is null', () => { | ||
| const node = sharedAttributes(graphNode(null, null), noop, true, false); | ||
| expect(node.parentId).toBeUndefined(); | ||
| }); | ||
|
|
||
| it('always sets id, position, type from the input node', () => { | ||
| const node = sharedAttributes(graphNode('dom-1', 'Finance'), noop, true, false); | ||
| expect(node.id).toBe('node-1'); | ||
| expect(node.position).toEqual({ x: 0, y: 0 }); | ||
| expect(node.type).toBe('dataProductNode'); | ||
| }); | ||
| }); | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
| // parseRegularNode passes extra_attributes through | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| describe('parseRegularNode', () => { | ||
| it('merges extra_attributes into data', () => { | ||
| const extra = { targetHandlePosition: Position.Left }; | ||
| const node = parseRegularNode(graphNode('dom-1', 'Finance'), noop, true, false, extra); | ||
| expect(node.data.targetHandlePosition).toBe('left'); | ||
| }); | ||
|
|
||
| it('preserves parentId set by sharedAttributes', () => { | ||
| const node = parseRegularNode(graphNode('dom-1', 'Finance'), noop, true, false, {}); | ||
| expect(node.parentId).toBe('dom-1'); | ||
| }); | ||
|
|
||
| it('exposes the domain name on node.data.domain', () => { | ||
| const node = parseRegularNode(graphNode('dom-1', 'Finance'), noop, true, false, {}); | ||
| expect(node.data.domain).toBe('Finance'); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am unsure what the tests add to be honest, the logic did not change? So unsure why they are required. Can you explain to me the reasoning for adding these?
The includes domain fields tests for example could just be the last 2 asserts that are added to
test_get_graph_data.