feat(bindings): add use_common_names for ingredient list normalization#91
Merged
feat(bindings): add use_common_names for ingredient list normalization#91
Conversation
commit: |
Expose common name resolution from aisle configuration in the bindings, allowing consumers to replace ingredient aliases (e.g. "apples") with their canonical common names (e.g. "apple gala") after combining.
dubadub
force-pushed
the
feat/bindings-use-common-names
branch
from
f7f44d7 to
242ddae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
use_common_names(list, aisle)exported function that replaces ingredient aliases with their canonical common names from aisle configurationcommon_name_for()method onAisleConffor case-insensitive common name lookupcommon_namescache duringparse_aisle_configfor efficient lookupsTest plan