Fix: prevent infinite recursion in deepmerge by extracting children prop #1933
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
xkelxmc
commented
May 18, 2025
xkelxmc
commented
- Updated ReactPlayer to destructure and exclude children from props before merging with defaultProps.
- This prevents deepmerge from causing infinite recursion when children are present.
- Children are now explicitly passed to the underlying player component, enabling custom content without recursion issues.
- Updated ReactPlayer to destructure and exclude children from props before merging with defaultProps. - This prevents deepmerge from causing infinite recursion when children are present. - Children are now explicitly passed to the underlying player component, enabling custom content without recursion issues.
luwes
reviewed
May 19, 2025
luwes
added a commit
that referenced
this pull request
May 19, 2025
…rop (#1933) * Fix: prevent infinite recursion in deepmerge by extracting children prop - Updated ReactPlayer to destructure and exclude children from props before merging with defaultProps. - This prevents deepmerge from causing infinite recursion when children are present. - Children are now explicitly passed to the underlying player component, enabling custom content without recursion issues. * Update src/ReactPlayer.tsx --------- Co-authored-by: Wesley Luyten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.