-
-
Notifications
You must be signed in to change notification settings - Fork 33
fix: update release workflow #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
00f7c75 to
03989ad
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
WalkthroughThis pull request adds Windows support to the Coolify CLI installation and release process. It introduces a PowerShell installer script ( ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/release-cli.yml(1 hunks).goreleaser.yml(1 hunks)README.md(1 hunks)scripts/install.ps1(1 hunks)scripts/install.sh(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
24-24: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
29-29: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
🪛 Shellcheck (0.11.0)
scripts/install.sh
[warning] 177-177: clean_version appears unused. Verify use (or export if used externally).
(SC2034)
🔇 Additional comments (1)
.goreleaser.yml (1)
25-39: Archive naming + Windows zip override line up with the installersThe new
checksumblock andarchives.coolify-archive(with Windowsformat_overrides→zip) match what both installers expect:
- Linux/macOS:
coolify-cli_<version>_<os>_<arch>.tar.gz(bash script strips leadingv).- Windows:
coolify-cli_<version>_windows_<arch>.zip(PowerShell script uses$cleanVersionsimilarly).Looks consistent and release‑friendly for a glorious self-hosted binary pipeline.
|
@YaRissi can you please check Coderabbit's review? They look valid for me. |
… tag push command
|
@andrasbacsai fixed the found issues |
|
Thank you for the PR! 💜 |
Changes