Skip to content

Conversation

@YaRissi
Copy link
Contributor

@YaRissi YaRissi commented Nov 10, 2025

Changes

  • Force push the tag to include the updated version. When using go install, Go fetches the latest tag, but the existing tag points to a commit before the version change, so it doesn't include the update
  • Fix install script, version formatting was wrong.
  • Adding install script for powershell/Windows
  • DEPRECATED: archives.builds should not be used anymore - https://goreleaser.com/deprecations/#archivesbuilds

@YaRissi YaRissi force-pushed the fix/version branch 2 times, most recently from 00f7c75 to 03989ad Compare November 16, 2025 15:26
@andrasbacsai
Copy link
Member

@coderabbitai review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 18, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 18, 2025

Walkthrough

This pull request adds Windows support to the Coolify CLI installation and release process. It introduces a PowerShell installer script (scripts/install.ps1) with platform detection, version management, and PATH configuration capabilities. The .goreleaser.yml is updated to generate Windows archives with checksums, and the GitHub Actions workflow is modified to retag releases on version updates. Documentation is expanded with Windows installation instructions in the README. A minor variable addition appears in the existing shell installer script.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb0bbfc and e071fd8.

📒 Files selected for processing (5)
  • .github/workflows/release-cli.yml (1 hunks)
  • .goreleaser.yml (1 hunks)
  • README.md (1 hunks)
  • scripts/install.ps1 (1 hunks)
  • scripts/install.sh (1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md

24-24: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)


29-29: Fenced code blocks should be surrounded by blank lines

(MD031, blanks-around-fences)

🪛 Shellcheck (0.11.0)
scripts/install.sh

[warning] 177-177: clean_version appears unused. Verify use (or export if used externally).

(SC2034)

🔇 Additional comments (1)
.goreleaser.yml (1)

25-39: Archive naming + Windows zip override line up with the installers

The new checksum block and archives.coolify-archive (with Windows format_overrideszip) match what both installers expect:

  • Linux/macOS: coolify-cli_<version>_<os>_<arch>.tar.gz (bash script strips leading v).
  • Windows: coolify-cli_<version>_windows_<arch>.zip (PowerShell script uses $cleanVersion similarly).

Looks consistent and release‑friendly for a glorious self-hosted binary pipeline.

@andrasbacsai
Copy link
Member

@YaRissi can you please check Coderabbit's review? They look valid for me.

@YaRissi
Copy link
Contributor Author

YaRissi commented Nov 20, 2025

@andrasbacsai fixed the found issues

@andrasbacsai
Copy link
Member

Thank you for the PR! 💜

@andrasbacsai andrasbacsai merged commit 188834f into coollabsio:v4.x Nov 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants