Fix is_buildtime JSON tag and add is_runtime, is_shared fields #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed critical bug where is_buildtime field was not unmarshaling from API responses due to JSON tag mismatch (was expecting 'is_build_time' with underscore but API returns 'is_buildtime' without underscore). Also added missing is_runtime and is_shared fields that are present in API responses. Added comprehensive tests for EnvironmentVariable model and service layer to ensure proper marshaling/unmarshaling of all fields. Achieved 100% coverage for EnvironmentVariable struct. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
is_buildtimefield was not unmarshaling from API responses due to JSON tag mismatchis_runtimeandis_sharedfields to EnvironmentVariable modelTesting
fix coollabsio/coolify#7365