fix: use bulk endpoint for service env update to resolve 404#59
Closed
aerocyberlabs wants to merge 1 commit intocoollabsio:v4.xfrom
Closed
fix: use bulk endpoint for service env update to resolve 404#59aerocyberlabs wants to merge 1 commit intocoollabsio:v4.xfrom
aerocyberlabs wants to merge 1 commit intocoollabsio:v4.xfrom
Conversation
The single-update endpoint PATCH /services/{uuid}/envs returns 404
for services. This fix routes single env var updates through the
bulk endpoint PATCH /services/{uuid}/envs/bulk, which works correctly.
The method fetches the current env var first to preserve existing
values for fields not being updated, then wraps the update in a
bulk request.
Fixes coollabsio#48
aerocyberlabs
force-pushed
the
fix/service-env-update-404
branch
from
e6df28d to
f945546
Compare
Member
|
Thanks for the PR. I will add it differently in #51, so I am closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #48 —
service env updatereturns 404 becausePATCH /services/{uuid}/envsdoesn't exist for services.Changes
Routes single env var updates through the working bulk endpoint
PATCH /services/{uuid}/envs/bulkinstead.The method:
How to test
Related
Found while building Paasman, a universal CLI for self-hosted PaaS platforms.