Add docker registry credentials store and app-level selection #7790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #2499
🎯 Partial Implementation: Docker Registry Credential Store
This PR implements the credential storage portion of #2499, providing a solid foundation for Docker registry authentication while deferring the image management UI to a future PR.
📦 What's Included
This PR addresses the credential store requirements from #2499:
✅ Credential Storage & Management
✅ Validation Improvements
✅ Test Coverage
🎥 Demo Video
Videos.Library.Loom.-.28.December.2025.fe45d731a47c49ee85c556ae5a9d62f9.mp4
🔧 Technical Changes
Backend:
app/Livewire/Security/DockerRegistry/Create.php- Removedrequired_withvalidation, added explicit null checksapp/Livewire/Security/DockerRegistry/Show.php- Fixed credential change validation to error both fieldsapp/Models/DockerRegistry.php- Model-level trimming viabooted()hook (already existed)Tests:
tests/Feature/DockerRegistryLivewireTest.php- Comprehensive Livewire component teststests/Unit/ApplicationDeploymentJobDockerRegistryLoginTest.php- Deployment integration tests📋 What's NOT Included (Future PR)
This PR intentionally excludes the image management UI portion of #2499:
❌ Deferred to Future PR:
🤔 Why Partial Implementation?
🚀 Immediate Value
Users can now:
📝 Testing
All tests passing locally and aligned with codebase patterns:
Test coverage includes:
🎯 Next Steps
After this PR merges, the image management UI (#2499 remaining portion) can be built on top of this credential foundation in a separate PR.
Related: Partially addresses #2499 (credential store only; image management deferred)